Re: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()

Michal Hocko
2020-10-16T13:45:01Z

On Fri 16-10-20 13:20:41, Tianxianting wrote:
> Thanks
> I understood what you said :)
> But whether it is proper to check reschedule in every loop when lock is taken?

I do not see any actual problem TBH. cond_resched is mostly to increase
interactivity for non preemptible kernel. It can reduce throughput but
this is a memory reclaim path and I do not expect this to contribute to
any moderate hot paths. Direct reclaim doesn't really count as a hot
path.

--
Michal Hocko
SUSE Labs