From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8789AC433DF for ; Mon, 19 Oct 2020 11:32:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 968B922268 for ; Mon, 19 Oct 2020 11:32:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="h4IZtlhS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 968B922268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A99D66B005D; Mon, 19 Oct 2020 07:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B466B0062; Mon, 19 Oct 2020 07:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A346B0068; Mon, 19 Oct 2020 07:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 665516B005D for ; Mon, 19 Oct 2020 07:32:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ED1633628 for ; Mon, 19 Oct 2020 11:32:27 +0000 (UTC) X-FDA: 77388461934.09.cats43_5700b7627236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id CED7F180AD811 for ; Mon, 19 Oct 2020 11:32:27 +0000 (UTC) X-HE-Tag: cats43_5700b7627236 X-Filterd-Recvd-Size: 2869 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 11:32:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603107146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dvULZg4AeKJjYxg9g9jVt+W6saMphhmth4XQTkKQjd8=; b=h4IZtlhSh/78EtJvOyS2N4H//4eFnA+cMEYbE50pbZKptm1tzRraBX4dfvIRvTNo4bhAxv t9gN+5gFrIx1juHpiFPlwtMIb7r8hYccTn9yDNm820pAo4UZMptDWqPDyvG2zkWAQOGvW6 ++VQfCbsSteKoSJScQNTy1kcSyVmVaI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0F191ABA2; Mon, 19 Oct 2020 11:32:26 +0000 (UTC) Date: Mon, 19 Oct 2020 13:32:24 +0200 From: Michal Hocko To: Oscar Salvador Cc: Shijie Luo , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linmiaohe@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH] mm: mempolicy: fix potential pte_unmap_unlock pte error Message-ID: <20201019113224.GD27114@dhcp22.suse.cz> References: <20201019074853.50856-1-luoshijie1@huawei.com> <20201019105029.GA18953@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019105029.GA18953@linux> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 19-10-20 12:50:34, Oscar Salvador wrote: > On Mon, Oct 19, 2020 at 03:48:53AM -0400, Shijie Luo wrote: > > When flags in queue_pages_pte_range don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL > > bits, code breaks and passing origin pte - 1 to pte_unmap_unlock seems like > > not a good idea. > > I think the above is already explained below? Yes > > queue_pages_pte_range can run in MPOL_MF_MOVE_ALL mode which doesn't migrate > > misplaced pages but returns with EIO when encountering such a page. Since > > commit a7f40cfe3b7a ("mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT > > is specified") and early break on the first pte in the range results in > > pte_unmap_unlock on an underflow pte. This can lead to lockups later on when > > somebody tries to lock the pte resp. page_table_lock again.. > > > > Fixes: a7f40cfe3b7a ("mm: mempolicy: make mbind() return -EIO when > > MPOL_MF_STRICT is specified") Cc: stable is due as well. There are even security concerns and I wouldn't be surprised if this gained a CVE. > > Signed-off-by: Shijie Luo > > Signed-off-by: Miaohe Lin > > Anyway, LGTM: > > Reviewed-by: Oscar Salvador Acked-by: Michal Hocko -- Michal Hocko SUSE Labs