From: Matthew Wilcox <willy@infradead.org>
To: Rik van Riel <riel@surriel.com>
Cc: Hugh Dickins <hughd@google.com>, Yu Xu <xuyu@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, kernel-team@fb.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp_mask
Date: Fri, 23 Oct 2020 22:09:35 +0100 [thread overview]
Message-ID: <20201023210935.GG20115@casper.infradead.org> (raw)
In-Reply-To: <20201023164708.5842f3fb@imladris.surriel.com>
On Fri, Oct 23, 2020 at 04:47:08PM -0400, Rik van Riel wrote:
> +++ b/include/linux/gfp.h
> @@ -614,6 +614,8 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask);
> extern void pm_restrict_gfp_mask(void);
> extern void pm_restore_gfp_mask(void);
>
> +extern gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma);
Without the types, the name of this function makes me think it allocates
something. Like alloc_hugepage_vma() does. With the types, it's obvious
that it gets the gfpmask. Can this patch rename it, perhaps to
gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma);
(hugepage is also ambiguous because it might be for hugetlbfs and we use,
eg, mapping_gfp_mask, not mapping_gfpmask).
prev parent reply other threads:[~2020-10-23 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 20:47 [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp_mask Rik van Riel
2020-10-23 21:09 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023210935.GG20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@surriel.com \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).