From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F253BC388F9 for ; Fri, 23 Oct 2020 21:09:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 158EB208E4 for ; Fri, 23 Oct 2020 21:09:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="h1zpfDEg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 158EB208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 088306B005D; Fri, 23 Oct 2020 17:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 012686B0062; Fri, 23 Oct 2020 17:09:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E42E66B0068; Fri, 23 Oct 2020 17:09:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id B40506B005D for ; Fri, 23 Oct 2020 17:09:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 60B838249980 for ; Fri, 23 Oct 2020 21:09:45 +0000 (UTC) X-FDA: 77404431930.10.coal63_411671d2725c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 40E0016A0D1 for ; Fri, 23 Oct 2020 21:09:45 +0000 (UTC) X-HE-Tag: coal63_411671d2725c X-Filterd-Recvd-Size: 2465 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 21:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=URKMB+l8lr+9mNV3UVoDcLLnTLfY/moWX1npvKJgs6g=; b=h1zpfDEgO90CZITyuoe0+XKlAq TnHTtX9Vne+elsmCyPlv4dvH419GP8HJgSvDu3d94ciTv985sCImVUZBEeL0vZqhVjHAzUjULo52q sCXqE7ziAOp8jR7OaSIIKh7yie11M7fYPPhtW3xc/oAykCJft7oTZ7Xl9uPsO8nbIT66/gj1++x4O taKLmy9FaBXu9Yeq8J0GUYMJceOOLFh+DQMbsiYQWhC1ZTH1jbnzdSC4VWha/lvYbSc9WvyMau3vP MLlAoaXg7e8952+Dv7X/kvELtT9vFDfDJHj9y5MV/vvnD/kwxmJXV19CQ7RHrmHj5KvJeptTbc7mH 3OC1Ml9Q==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW4Jb-0002Lv-VJ; Fri, 23 Oct 2020 21:09:36 +0000 Date: Fri, 23 Oct 2020 22:09:35 +0100 From: Matthew Wilcox To: Rik van Riel Cc: Hugh Dickins , Yu Xu , Andrew Morton , Mel Gorman , Andrea Arcangeli , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp_mask Message-ID: <20201023210935.GG20115@casper.infradead.org> References: <20201023164708.5842f3fb@imladris.surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023164708.5842f3fb@imladris.surriel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 23, 2020 at 04:47:08PM -0400, Rik van Riel wrote: > +++ b/include/linux/gfp.h > @@ -614,6 +614,8 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask); > extern void pm_restrict_gfp_mask(void); > extern void pm_restore_gfp_mask(void); > > +extern gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma); Without the types, the name of this function makes me think it allocates something. Like alloc_hugepage_vma() does. With the types, it's obvious that it gets the gfpmask. Can this patch rename it, perhaps to gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma); (hugepage is also ambiguous because it might be for hugetlbfs and we use, eg, mapping_gfp_mask, not mapping_gfpmask).