From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203A8C4742C for ; Fri, 30 Oct 2020 00:04:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BCA520838 for ; Fri, 30 Oct 2020 00:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d/d1CRY7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCA520838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84A2E6B005C; Thu, 29 Oct 2020 20:04:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FB1D6B005D; Thu, 29 Oct 2020 20:04:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69CBA6B0062; Thu, 29 Oct 2020 20:04:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 3CB556B005C for ; Thu, 29 Oct 2020 20:04:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CBAE91EE6 for ; Fri, 30 Oct 2020 00:04:44 +0000 (UTC) X-FDA: 77426645688.03.girls21_2d0edfc27291 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id A92C528A4E8 for ; Fri, 30 Oct 2020 00:04:44 +0000 (UTC) X-HE-Tag: girls21_2d0edfc27291 X-Filterd-Recvd-Size: 3591 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 00:04:44 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id a20so4918492ilk.13 for ; Thu, 29 Oct 2020 17:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9gRYezkbnMXFdqY4A90rm34YJ2lybUPYTL7SBNEMZ84=; b=d/d1CRY7661eKRjem/vI1XNo9H2M5TvyRItjdcOZwRWpij48kIRCkBXeTi0TesOG4s +JfOwnsqwOdhKTk2YIc1TqAW0HCchHYc83fKV9vRbNSeVMYs5OlIKFComk7iQv0GfT5b S4SE9arI5fg3RqIP9t0jcfkqXKoUfbcRVwrbrdfd/eFcGn4h2B6UMUfOw8k84jyacfTD Toswv2ay79kFj8aBtryd3GkqLyvKq3JgivzfZ/XNjKyCX+zyvmA5NOW2kVc3EiH//scm +VlqlLyeBGDl9YTZH026+/icwiUh7j6VJxxpiilwghenbEgpaWdrUqUHxkvy5nUY+XJh HtDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9gRYezkbnMXFdqY4A90rm34YJ2lybUPYTL7SBNEMZ84=; b=kNPxhQLTQsTISPwbyIJUXIEmrG2RK/+M27WlrJQ5thG5kSf0GD8/HV4kG2CBdsNdJf JmegiQ0g2DeQCa/5XFC7Y9dcpTXUbqwtIUusFqd921DX9zWjBk1MY4P/SHtpquzOZ3nc 5WxkpglhpcYQTiEJVf0Gq2a9RgDhDeAuzw96OdWnWWZo3TDyDj6S100NuOSPbNr/U8aW l0w02U0pDeSR62PyRkzT8sCunbWmqo5et7AUYERqpvMmAqCaVHW4xUoiOfBPmZ+bvG+S yXrGPd8wHirDXyiF2FRR2hqlqK8HYH6QRSbYW0qCOsL/L1tphtokFFX4AWWGcoxmLi+Y ONQw== X-Gm-Message-State: AOAM531fW8fH4C49FRCOmxjjUR8aCzxG7UHwp3uth03zDeJ2d6nUr8Mm 1ZotrW8Tw8bB1IWrAGsKsQ== X-Google-Smtp-Source: ABdhPJy99muaofx0ikA0ilNe6zU834F1hUXtY4GBrlHs+u/D0NYom356JcTmb59mOATTxstXKD5qAg== X-Received: by 2002:a92:db05:: with SMTP id b5mr5130778iln.279.1604016283633; Thu, 29 Oct 2020 17:04:43 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id 192sm4339067ilc.31.2020.10.29.17.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 17:04:43 -0700 (PDT) Date: Thu, 29 Oct 2020 20:04:38 -0400 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/19] mm/filemap: Rename generic_file_buffered_read subfunctions Message-ID: <20201030000438.GA2123636@moria.home.lan> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029193405.29125-6-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 07:33:51PM +0000, Matthew Wilcox (Oracle) wrote: > The recent split of generic_file_buffered_read() created some very > long function names which are hard to distinguish from each other. > Rename as follows: > > generic_file_buffered_read_readpage -> gfbr_read_page > generic_file_buffered_read_pagenotuptodate -> gfbr_update_page > generic_file_buffered_read_no_cached_page -> gfbr_create_page > generic_file_buffered_read_get_pages -> gfbr_get_pages > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet