From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C13DC388F9 for ; Sat, 31 Oct 2020 16:20:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A357622275 for ; Sat, 31 Oct 2020 16:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RT6Jjtaa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A357622275 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A873B6B005C; Sat, 31 Oct 2020 12:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A10BF6B006C; Sat, 31 Oct 2020 12:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FEE96B006E; Sat, 31 Oct 2020 12:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 602876B005C for ; Sat, 31 Oct 2020 12:20:15 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E90F282499A8 for ; Sat, 31 Oct 2020 16:20:14 +0000 (UTC) X-FDA: 77432732748.06.spoon88_300c0d8272a0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C351810039B4A for ; Sat, 31 Oct 2020 16:20:14 +0000 (UTC) X-HE-Tag: spoon88_300c0d8272a0 X-Filterd-Recvd-Size: 1843 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 16:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k1PEEXuWR7bG1QQkR4pN0hbrop1yryXTxtXR/XMLLqs=; b=RT6JjtaaaTUBjjfbDoIvPlTg5N HDINOp8k3xwu/8jorAzp1pigtieOSreHLWxdiorkRz/k+eXhpzU9UilUV0ZdY9eCSHgvxrezJXWsH ICFxQ8lVXUftHiHKyoDBP9SPVBUWUhGUxqy8OZP9RaevkVOa+SAinMIbGJ2Px8iiupyzywkQwCDRo 6j7as1OJqyRKlb6x8KWIMgbSCC882H3Y8hlUso9K+KwPuu7DJFTOCBZpNmjhg3Sd9Hx7z0bjJbOWn zNdd9Iif7FZwOGc/PiYA589E0pdAXedrUA7++GqJw3Egw4qdIbGhhvMUc+L5ZHJIBxgPXns7wS40G m4OVHzwA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYtbs-00067D-NC; Sat, 31 Oct 2020 16:20:08 +0000 Date: Sat, 31 Oct 2020 16:20:08 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/13] mm: simplify generic_file_buffered_read_no_cached_page Message-ID: <20201031162008.GR27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031090004.452516-6-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 31, 2020 at 09:59:56AM +0100, Christoph Hellwig wrote: > - page = page_cache_alloc(mapping); > + *page = page_cache_alloc(mapping); > if (!page) if (!*page)