From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495CFC388F9 for ; Sat, 31 Oct 2020 16:28:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6575F22259 for ; Sat, 31 Oct 2020 16:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Cnn0KSYX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6575F22259 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C4C66B006C; Sat, 31 Oct 2020 12:28:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8753F6B0070; Sat, 31 Oct 2020 12:28:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AAD6B0071; Sat, 31 Oct 2020 12:28:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 4A4956B006C for ; Sat, 31 Oct 2020 12:28:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DB4DA180AD802 for ; Sat, 31 Oct 2020 16:28:18 +0000 (UTC) X-FDA: 77432753076.20.line03_4401728272a0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id BD6B8180C0609 for ; Sat, 31 Oct 2020 16:28:18 +0000 (UTC) X-HE-Tag: line03_4401728272a0 X-Filterd-Recvd-Size: 1989 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 16:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Wd2kP/lRPNbQUQ7UYe1shx1WBoUnLjGTXchbmVExCmA=; b=Cnn0KSYXyQKoeUziSms7k26mae Q/QG+Pt+3pyr70440sNSeTvKjnkM0v8tMkcTrzJrku/lJ/WaWAaiME7pe3S40aEFSUSC2EZGKQywl UJlkrl8b1x0vATPa138VI/ZY9/uMxW1UjhSn+hJASwcpyfblNbDaja4rT0NsLlp8YgwkhJ6xJ5h9M kI9KhPiaeiBBOs6avuMspbHYGcLD0Zgp2aTdWbdE2MFnL9cI+d39OwGkP5BfwLp29MfEztY7Wt5l7 dbbV6BDHgpKwIvLbCPRpoceKc4oSEEH/t41u9W5lB7Xdbq/6NXefGHqK3fKh1qQ21Q7S2yZ1urxou zBjBOr3Q==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYtjh-0006Uk-I9; Sat, 31 Oct 2020 16:28:13 +0000 Date: Sat, 31 Oct 2020 16:28:13 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/13] mm: simplify generic_file_buffered_read_no_cached_page Message-ID: <20201031162813.GS27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031090004.452516-6-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 31, 2020 at 09:59:56AM +0100, Christoph Hellwig wrote: > +static int filemap_new_page(struct kiocb *iocb, struct iov_iter *iter, > + struct page **page) I don't like this calling convention. It's too easy to get it wrong, as you demonstrated. I preferred the way Kent had it with returning an ERR_PTR.