From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E639C388F9 for ; Sun, 1 Nov 2020 10:51:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 16C2D20791 for ; Sun, 1 Nov 2020 10:51:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16C2D20791 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 930D16B0074; Sun, 1 Nov 2020 05:51:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D03B6B0075; Sun, 1 Nov 2020 05:51:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8C96B0078; Sun, 1 Nov 2020 05:51:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 509F56B0074 for ; Sun, 1 Nov 2020 05:51:17 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E7FDD824999B for ; Sun, 1 Nov 2020 10:51:16 +0000 (UTC) X-FDA: 77435532552.08.dolls93_0012275272a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id CE03E1819E772 for ; Sun, 1 Nov 2020 10:51:16 +0000 (UTC) X-HE-Tag: dolls93_0012275272a6 X-Filterd-Recvd-Size: 1609 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 10:51:16 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2CCDF6736F; Sun, 1 Nov 2020 11:51:13 +0100 (CET) Date: Sun, 1 Nov 2020 11:51:12 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/13] mm: handle readahead in generic_file_buffered_read_pagenotuptodate Message-ID: <20201101105112.GA26860@lst.de> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-5-hch@lst.de> <20201031170646.GT27442@casper.infradead.org> <20201101103144.GC26447@lst.de> <20201101104958.GU27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101104958.GU27442@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 01, 2020 at 10:49:58AM +0000, Matthew Wilcox wrote: > On Sun, Nov 01, 2020 at 11:31:44AM +0100, Christoph Hellwig wrote: > > This looks sensible, but goes beyond the simple refactoring I had > > intended. Let me take a more detailed look at your series (I had just > > updated my existing series to to the latest linux-next) and see how > > it can nicely fit in. > > I'm also working on merging our two series. I'm just about there ... Heh, same here.