From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E98DC55178 for ; Sun, 1 Nov 2020 11:04:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0ED6207F7 for ; Sun, 1 Nov 2020 11:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KeP9tipC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0ED6207F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D084F6B0036; Sun, 1 Nov 2020 06:04:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB8BD6B005C; Sun, 1 Nov 2020 06:04:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCDB26B005D; Sun, 1 Nov 2020 06:04:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 922646B0036 for ; Sun, 1 Nov 2020 06:04:11 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 304FD180AD815 for ; Sun, 1 Nov 2020 11:04:11 +0000 (UTC) X-FDA: 77435565102.17.crown02_3d0f414272a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 13883180D0180 for ; Sun, 1 Nov 2020 11:04:11 +0000 (UTC) X-HE-Tag: crown02_3d0f414272a6 X-Filterd-Recvd-Size: 2828 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 11:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6C2hTaQSGmv10YNbIHkE/EE0lKL7K5w8Au0qd2PPPQk=; b=KeP9tipCGPHH3YhPRnKk8ZWuE6 5X1H9N+Ha1sw9pikrarTs9Zxx4eurpa12Eku96lyfuXLkYEChZ/M6irGgCFtlFPIfxioYB4UybZB3 zOt5+nlRC7C36txQotWUlaygGlNeyA88rULKImdjykaldwB9enYQwwQQSIHVeMsuIXjyU/eVN0yto 0wa7Zbsts29UgNQplP1WoZi3QFgArS6J+fdnVaA1bK4Tr9sd99XOQ/WT8NYyREn+EhBEuMyVVdDMq SkoBqippx8ieNxVIrmlJrfw6/lLYtqFLSzSJCDGHF8OyA3KcZVd2mAmwNmhlWJcgQco5gEU1FdXKw bGkaKdgw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZB9a-00032W-M1; Sun, 01 Nov 2020 11:04:07 +0000 Date: Sun, 1 Nov 2020 11:04:06 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/13] mm: handle readahead in generic_file_buffered_read_pagenotuptodate Message-ID: <20201101110406.GV27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-5-hch@lst.de> <20201031170646.GT27442@casper.infradead.org> <20201101103144.GC26447@lst.de> <20201101104958.GU27442@casper.infradead.org> <20201101105112.GA26860@lst.de> <20201101105158.GA26874@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101105158.GA26874@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 01, 2020 at 11:51:58AM +0100, Christoph Hellwig wrote: > On Sun, Nov 01, 2020 at 11:51:12AM +0100, Christoph Hellwig wrote: > > On Sun, Nov 01, 2020 at 10:49:58AM +0000, Matthew Wilcox wrote: > > > On Sun, Nov 01, 2020 at 11:31:44AM +0100, Christoph Hellwig wrote: > > > > This looks sensible, but goes beyond the simple refactoring I had > > > > intended. Let me take a more detailed look at your series (I had just > > > > updated my existing series to to the latest linux-next) and see how > > > > it can nicely fit in. > > > > > > I'm also working on merging our two series. I'm just about there ... > > > > Heh, same here. > > I'll stop for now. http://git.infradead.org/users/willy/pagecache.git/shortlog/refs/heads/next is what i currently have. Haven't pulled in everything from you; certainly not renaming generic_file_buffered_read to filemap_read(), which is awesome. i'm about 500 seconds into an xfstests run.