From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3491DC388F9 for ; Mon, 2 Nov 2020 19:38:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B4CC52225E for ; Mon, 2 Nov 2020 19:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y1TlIFDu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4CC52225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29C9F6B0036; Mon, 2 Nov 2020 14:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24EA66B005C; Mon, 2 Nov 2020 14:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D376B0068; Mon, 2 Nov 2020 14:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id DC57B6B0036 for ; Mon, 2 Nov 2020 14:38:45 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8C17D8249980 for ; Mon, 2 Nov 2020 19:38:45 +0000 (UTC) X-FDA: 77440490610.28.door92_591358f272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 631A36C2D for ; Mon, 2 Nov 2020 19:38:45 +0000 (UTC) X-HE-Tag: door92_591358f272b2 X-Filterd-Recvd-Size: 3550 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 19:38:44 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id n63so4491458qte.4 for ; Mon, 02 Nov 2020 11:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vrqSsdCV/rIQCp2IIgQgFHq93wNws+wEPI1TpeJQPKg=; b=Y1TlIFDueG6X0facR+kMZCi31dxb4Z6XChlS6AWH7InUjfzmET1zsR6JsE4WpmrSyY G7u5I1W4iVKbI4keNcIptTzj2DLE8SWIDf0cvj4iSA/dEHuziJRUtUuGi5iqnHO/vojS XRbhTnCXN3T7katAEvHn8T544zF4pi1o9pNXUn9kk0mc8ifjKkHTMPfBCwUBroU8YPGP CYrgJTxLdB+PrelmqGHhpoQlvHCIcN602vVghoHT3+C0LM7xySSb15b4PtCfu+igZbGF WlBX++ccZRWc01w80eK6fb/PulMtkUYQzuP30KfM3liRVdl3kvWhfro9vBIhHpVarsgS 1YNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vrqSsdCV/rIQCp2IIgQgFHq93wNws+wEPI1TpeJQPKg=; b=MHLMXxOIh4rZ9T9pojsA5+3A5KKN18zbU1oG16Vv3BcfTE1BwhL4DVpxRhTcC//8hK 3V6aLE9+UHZ9EaAT1VE0f9+KGpIWFUsUg31RBBOVDjiYi5stuOnTcUv7Cmf68eYfZWbQ VOC1PpN9v/k4zJoxEXiTpz/4tEqUjnxithiK4X7Pc/tHrVA99n+6/DPA+8LOu2YJdmnc HNmy2EwQgvjA4idAMqsGGB8LpInP+skdEOgGaTJ7h4R6Pdzmsxj0SKrONX+shea+3UPw 9CTIslSS6eDuepynNSOxoPRU2eoMGhP9TfQO/bxJ9/JBPN4lik1SxhFbUN9ccuV214QN IWOg== X-Gm-Message-State: AOAM531hIrLw4DwTeGuPcYUI26fMRXKV5QfKGw/XTTK79Uh3FQbwduM/ ETi3ZS5m5XxHWmPJMm2a/w== X-Google-Smtp-Source: ABdhPJwlRsFUXcEZjGbvSlSN7PjHMfCsBrNeEtJLPDmlgvhyVloBnB4kpCVUciPgxJlwbe51kEzYfA== X-Received: by 2002:a05:622a:2d4:: with SMTP id a20mr12263199qtx.349.1604345924396; Mon, 02 Nov 2020 11:38:44 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id 69sm8799281qko.48.2020.11.02.11.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 11:38:43 -0800 (PST) Date: Mon, 2 Nov 2020 14:38:42 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 08/17] mm/filemap: Change filemap_create_page arguments Message-ID: <20201102193842.GL2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-9-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:03PM +0000, Matthew Wilcox (Oracle) wrote: > filemap_create_page() doesn't need the iocb or the iter. It just needs > the file and the index. Move the iocb flag checks to the caller. We can > skip checking GFP_NOIO as that's checked a few lines earlier. There's no > need to fall through to filemap_update_page() -- if filemap_create_page > couldn't update it, filemap_update_page will not be able to. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet