From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515B1C00A89 for ; Mon, 2 Nov 2020 20:05:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99A6021D40 for ; Mon, 2 Nov 2020 20:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfvvfRsC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99A6021D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B0A406B0036; Mon, 2 Nov 2020 15:05:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A95206B005C; Mon, 2 Nov 2020 15:05:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95D856B0068; Mon, 2 Nov 2020 15:05:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 6595A6B0036 for ; Mon, 2 Nov 2020 15:05:18 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E66D7349B for ; Mon, 2 Nov 2020 20:05:17 +0000 (UTC) X-FDA: 77440557474.30.room03_5515e5d272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 9EF6A180B3C8B for ; Mon, 2 Nov 2020 20:05:17 +0000 (UTC) X-HE-Tag: room03_5515e5d272b2 X-Filterd-Recvd-Size: 3293 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:05:17 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id s14so12611869qkg.11 for ; Mon, 02 Nov 2020 12:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ii/vX3wIfh9EjK8XSXKI6R+0Ea/Qhhx0+Dtik41yeE0=; b=CfvvfRsCkNvvfcv4S256A5gAwSpz3rjTXflyWH0B1pS2kCdhhUj+18/4vUTcPG064H VVZh4BFTKtqoUY5PmyODLjpu3E4knctxEMsoTidtE58ikRxGmYEcLy0PmBgHUzTEysWS KMHXoAeLjGS3C66MP2/21bb+NxXs7oMeADkhtEw8ruQ2FhjGci/D6O7vRJ+3TT049l9M xpI5P5dLSpkNol49tgydBSxEmuljqd8DRef/syETwZduoBkTl75uieLdXX+ODUtyikEg FnfMMBazkyDBPJhNTx+US8SmRSpccUZG7I7l8I83xMTlWIWZO/sTj1EKWQqAhodDx6YB lUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ii/vX3wIfh9EjK8XSXKI6R+0Ea/Qhhx0+Dtik41yeE0=; b=nI/cGScEDyhONQx0P3U4MIOftHo+cFDoLr1zY5IAGtsBucJ2NzeBL/QPLK8/gYI0Cy ytpmidHIv9jrU0ZQH0vW62wep23SudEfqzCLQFwxLzLXSz+k7DL/p8tmZYHOi32Kbtbz Ii4U1UnFAvO1kB7ymssdA+PJtn8L15p3OC9jk53k7awyDwt2oHBFOI57E832FVvbh+lq izYa98kQsg9VMP/GgBs2haCLLTjKn6xJFbXLY70b0jQYv1j+Vg8/DYH/IMQqr6yw3WCU Ceq6xsHMqLZVsfIS3BPEGeEMY0HfmM81fzR3LRqPOm5+828ujtcFDLhiNEHpsD+gE0jG aFFA== X-Gm-Message-State: AOAM533uWrGrG7mQqTFge37Vz6z6WI2qeoQWgQG7ZHDwf2W5UfsvQTrU 9Wi5FANmwKd9uTc2mE+m0A== X-Google-Smtp-Source: ABdhPJx7oRaSUvjdMlIqg4AVU+/4Bnz/DMtcrZVIR6KasBpGNOkDwHmaAbbCmcbdGpb6PtJln4aHmQ== X-Received: by 2002:a37:4692:: with SMTP id t140mr17138786qka.275.1604347516764; Mon, 02 Nov 2020 12:05:16 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id z134sm8917191qka.21.2020.11.02.12.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:05:16 -0800 (PST) Date: Mon, 2 Nov 2020 15:05:14 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 14/17] mm/filemap: Restructure filemap_get_pages Message-ID: <20201102200514.GR2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-15-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:09PM +0000, Matthew Wilcox (Oracle) wrote: > Avoid a goto, and by the time we get to calling filemap_update_page(), > we definitely have at least one page. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet