From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C0DC00A89 for ; Mon, 2 Nov 2020 20:06:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 284CE20870 for ; Mon, 2 Nov 2020 20:06:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c7oyqMZN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 284CE20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 848A36B0036; Mon, 2 Nov 2020 15:06:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D1986B005C; Mon, 2 Nov 2020 15:06:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6503E6B0068; Mon, 2 Nov 2020 15:06:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 2ECDE6B0036 for ; Mon, 2 Nov 2020 15:06:23 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C81EA181AEF0B for ; Mon, 2 Nov 2020 20:06:22 +0000 (UTC) X-FDA: 77440560204.18.scent55_5d07eb0272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 6D872100ED0DB for ; Mon, 2 Nov 2020 20:06:22 +0000 (UTC) X-HE-Tag: scent55_5d07eb0272b2 X-Filterd-Recvd-Size: 3362 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:06:21 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id r8so10069689qtp.13 for ; Mon, 02 Nov 2020 12:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IhFfXSIkOhUO5GsiKgFe6mbFiJFskGfANVrm7Fl4UcY=; b=c7oyqMZN3m3/OdJEJkXjKYZ/R5uxoI637ahr3XVstdTu2vGwLdxyWz8FJFW/j+sypR it/5UCdprGWYkUAsi4O9XTMb0+soNPtNVHj0BPZnsWgVDzr++7M1FWEBvkmAek8vA8Ft wDx5n666AOad1f1SJiNQxDd8eBQvEjGFjI8JETCKKQcXWWrE4sS/ZYeFSpaToWB/a465 QGh4/xUcAFYd+Vw+YADiLylNpS/PTLPoxz8y2L0I54N93BdbT6QdksB/a+V6nAD8JlSx Yh3/gkK/OnXO4z8XG4dTY0WwvFt/AZ3sB1QyXeVbB+Ub59ZV/bqEiwMaMHo3yGT2gKX9 Pg6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IhFfXSIkOhUO5GsiKgFe6mbFiJFskGfANVrm7Fl4UcY=; b=sefN/khophg8SGDE3MvgjjBIo4zcg5vrsI7CxqLeI/oXrtJGGqjz95MF3ME1qbjEHS ZKbhk7MKUBq5Ec8nZBhJRs4dHcU24v5tJz+C1s+67gypd3q3DSY9nPD6d+g+BHfdsER3 Hte51yHVSbEgDYmA9Ot4gsCJFxDkWCeVFiwSvaBsn2I/6Qx2jtJFQemcrHtDDw0sVmh6 ziJxC6EdctU53zHyfTQ2IWmAwt2JLyIgk8cqyEaNAdojZVuULyvhLFYJEyvLqEvtxJ5n Au2QQ12g3mh/rX2V8bc5DNYZJN45iItferwvg74jCHZbfo3IQ5u3JOwD3F38QOKTr5Oi xLyg== X-Gm-Message-State: AOAM532NWz+aZj81ApxEo5OY9ORjFn9js4pgRhenloLizApdXmjIv2za 6axrtek02+myrq5orm2jAw== X-Google-Smtp-Source: ABdhPJzphEc3oUZrFC7IJ1Oo10vnHJVYjIZNaZa6tOgt47B6lfqEm1NfbfVt2Ag8pEIRQZc4TGyFDw== X-Received: by 2002:ac8:5cc2:: with SMTP id s2mr15667004qta.314.1604347581500; Mon, 02 Nov 2020 12:06:21 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id q20sm8836491qtl.69.2020.11.02.12.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:06:21 -0800 (PST) Date: Mon, 2 Nov 2020 15:06:19 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 15/17] mm/filemap: Don't relock the page after calling readpage Message-ID: <20201102200619.GS2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-16-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:10PM +0000, Matthew Wilcox (Oracle) wrote: > We don't need to get the page lock again; we just need to wait for > the I/O to finish, so use wait_on_page_locked_killable() like the > other callers of ->readpage. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet