From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10B1C00A89 for ; Mon, 2 Nov 2020 20:09:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3154020870 for ; Mon, 2 Nov 2020 20:09:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NhXZmK3d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3154020870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E1BB6B0068; Mon, 2 Nov 2020 15:09:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 692B66B006C; Mon, 2 Nov 2020 15:09:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E7386B006E; Mon, 2 Nov 2020 15:09:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 1E5106B0068 for ; Mon, 2 Nov 2020 15:09:26 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B10C91EE6 for ; Mon, 2 Nov 2020 20:09:25 +0000 (UTC) X-FDA: 77440567890.26.trees48_47140b3272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 8FF0E1804B65A for ; Mon, 2 Nov 2020 20:09:25 +0000 (UTC) X-HE-Tag: trees48_47140b3272b2 X-Filterd-Recvd-Size: 2073 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hVs0L5lRvwGWFdFk+32L8kAt1nvc+7ExB/JaU7+DRGo=; b=NhXZmK3d8d82Pb8COcVRPISLHP xCOfeOwY1bJdC77W6nrCJTvWeATuyNRRi0R2lGOicFhtLU5v0tVenJd156Ud5Xw8tmOlju47y5bMq DW9L923ppplgpTiLRin4CLpuzL5PdmwRJI8kPqwoR0sTgWvCezT/PDo+aybTszaqeT1uMu3w3iNHA yUj91NEj3PzB5PfQI2hToF+IUke06uez+UG7QXluAr1rDMryA5HL3nhCszjZhBhpflpgvalnh12ii eQg70zhCrYE3xJxuMRCaGBglnrjfzZXjmSMQ++QX9m0zGBwQBojgYcppMRFBE+RZOb9rAXUwTY1/U HTFWrPLA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZg8n-0003gI-MV; Mon, 02 Nov 2020 20:09:21 +0000 Date: Mon, 2 Nov 2020 20:09:21 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 11/17] mm/filemap: Add filemap_range_uptodate Message-ID: <20201102200921.GR27442@casper.infradead.org> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-12-willy@infradead.org> <20201102195056.GO2123636@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102195056.GO2123636@moria.home.lan> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 02:50:56PM -0500, Kent Overstreet wrote: > On Mon, Nov 02, 2020 at 06:43:06PM +0000, Matthew Wilcox (Oracle) wrote: > > Move the complicated condition and the calculations out of > > filemap_update_page() into its own function. > > You're missing a signed-off-by > > Reviewed-by: Kent Overstreet Oops. Signed-off-by: Matthew Wilcox (Oracle)