From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03370C00A89 for ; Mon, 2 Nov 2020 20:14:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5145A21534 for ; Mon, 2 Nov 2020 20:14:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pOiNtPTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5145A21534 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C2CC16B0068; Mon, 2 Nov 2020 15:14:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C05DF6B006C; Mon, 2 Nov 2020 15:14:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7AE6B006E; Mon, 2 Nov 2020 15:14:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 781EA6B0068 for ; Mon, 2 Nov 2020 15:14:15 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1DCA38249980 for ; Mon, 2 Nov 2020 20:14:15 +0000 (UTC) X-FDA: 77440580070.21.boot70_581572b272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 00939180442C3 for ; Mon, 2 Nov 2020 20:14:14 +0000 (UTC) X-HE-Tag: boot70_581572b272b2 X-Filterd-Recvd-Size: 4714 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:14:14 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id r7so12702399qkf.3 for ; Mon, 02 Nov 2020 12:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VZ7nDwMeiwbR1b3qQePaTcRxk9HIqyc702Z9EwSs1yc=; b=pOiNtPTkYQNgP5/gIzQfShOSv/zRF5Ot42DlqvAIl5+sKQ/z28CYjl3e6KostwhuqI ffA8oLPXRmHbTbZGDZ3UOA8zDJVCCVK5YmTOu9SewVQfXsikVy0gLxnMo1FTVwDoiH17 JLofrUeWHDsFLCKK7HbpYWBKFnABunUTFyC9bAww3qpXzSqprylOFwvrWgzyQlT2Attk r3O9xmihHgEMgzHaSAsAkhcwLKpk+TLyURfaZaH4V18zk6yPNyZGbEwcg8GZeokyjklb rlfPcDLWOySI03KKQrBkJ6r5mO65eUC5Ckb65BM68OfjsouBvRV41Wc58PZUYUpJOKf4 myWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VZ7nDwMeiwbR1b3qQePaTcRxk9HIqyc702Z9EwSs1yc=; b=oiKq8keh+My0cF7PUNt5osB2mHNlVm1SxBSjCXwXq05/0r+9bvbvX02Y7yXBoPq7/q Nr1uSVdTKZSKr0VotRCpVx3k6SEiz8+YDlGnYpy11SgzuNkJyFJ0SN+PVcFcdJKAhavG ofrAdayR9ZdGVVc3vg7Mspggz6SgFhmjfu2ATSuk8bT3q7shLs882lomyeFVpCdpmmBj reMj6ZjR+nocZL5r5MtUz/D57vfrPJrs20wjaZcuj7s5sxeRjvt3JcnBn++HpVgeKjFn ILwWqsiQelF+iitfl3GRTOcf84LhwdvLKop4yn+I69gZ3ZgJ6OFbUTMG0Sh6W8Kn+6FO utZA== X-Gm-Message-State: AOAM531rp2xLnssZ+krl9de+gD1sOaTkYnE2omd54Se8N86Elqct2ds9 80pOzCUzaikSInZGrBiXdg== X-Google-Smtp-Source: ABdhPJzaZrP7QgGzs8Bf3H55ClDQGO+8Hp5k9NurvTlpcmLD3IfZuqFSBeLZ33CcIdViE6H8fMh4qg== X-Received: by 2002:a37:8984:: with SMTP id l126mr15730269qkd.443.1604348053978; Mon, 02 Nov 2020 12:14:13 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id n63sm8831097qka.45.2020.11.02.12.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:14:13 -0800 (PST) Date: Mon, 2 Nov 2020 15:14:11 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 00/17] Refactor generic_file_buffered_read Message-ID: <20201102201411.GV2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-1-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:42:55PM +0000, Matthew Wilcox (Oracle) wrote: > This is a combination of Christoph's work to refactor > generic_file_buffered_read() and my THP support on top of Kent's patches > which are currently in -mm. I really like where this ended up. Nice patch series, I had a look at the results in your git tree and I really like where things ended up too. > > Christoph Hellwig (2): > mm/filemap: rename generic_file_buffered_read to filemap_read > mm: simplify generic_file_read_iter > > Matthew Wilcox (Oracle) (15): > mm/filemap: Rename generic_file_buffered_read subfunctions > mm/filemap: Use THPs in generic_file_buffered_read > mm/filemap: Pass a sleep state to put_and_wait_on_page_locked > mm/filemap: Support readpage splitting a page > mm/filemap: Inline __wait_on_page_locked_async into caller > mm/filemap: Don't call ->readpage if IOCB_WAITQ is set > mm/filemap: Change filemap_read_page calling conventions > mm/filemap: Change filemap_create_page arguments > mm/filemap: Convert filemap_update_page to return an errno > mm/filemap: Move the iocb checks into filemap_update_page > mm/filemap: Add filemap_range_uptodate > mm/filemap: Split filemap_readahead out of filemap_get_pages > mm/filemap: Remove parameters from filemap_update_page() > mm/filemap: Restructure filemap_get_pages > mm/filemap: Don't relock the page after calling readpage > > fs/btrfs/file.c | 2 +- > include/linux/fs.h | 4 +- > include/linux/pagemap.h | 3 +- > mm/filemap.c | 493 +++++++++++++++++++--------------------- > mm/huge_memory.c | 4 +- > mm/migrate.c | 4 +- > 6 files changed, 237 insertions(+), 273 deletions(-) > > -- > 2.28.0 >