From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16104C388F2 for ; Tue, 3 Nov 2020 07:31:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB7E122226 for ; Tue, 3 Nov 2020 07:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB7E122226 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5AE116B006E; Tue, 3 Nov 2020 02:31:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55E326B0070; Tue, 3 Nov 2020 02:31:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44E146B0071; Tue, 3 Nov 2020 02:31:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 18FC36B006E for ; Tue, 3 Nov 2020 02:31:50 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B6ACC8249980 for ; Tue, 3 Nov 2020 07:31:49 +0000 (UTC) X-FDA: 77442287538.23.judge60_3e0bcc7272b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9B89837609 for ; Tue, 3 Nov 2020 07:31:49 +0000 (UTC) X-HE-Tag: judge60_3e0bcc7272b6 X-Filterd-Recvd-Size: 1329 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 07:31:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0C56567373; Tue, 3 Nov 2020 08:31:47 +0100 (CET) Date: Tue, 3 Nov 2020 08:31:46 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH 06/17] mm/filemap: Don't call ->readpage if IOCB_WAITQ is set Message-ID: <20201103073146.GF8389@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-7-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000078, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:01PM +0000, Matthew Wilcox (Oracle) wrote: > The readpage operation can block in many (most?) filesystems, so we > should punt to a work queue instead of calling it. This was the last > caller of lock_page_async(), so remove it. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig