From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97658C2D0A3 for ; Tue, 3 Nov 2020 08:36:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB2F122400 for ; Tue, 3 Nov 2020 08:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Tz2Yhfv/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB2F122400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C57A16B005C; Tue, 3 Nov 2020 03:36:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C08D56B005D; Tue, 3 Nov 2020 03:36:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD2416B0068; Tue, 3 Nov 2020 03:36:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 7C0F96B005C for ; Tue, 3 Nov 2020 03:36:07 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1CB723632 for ; Tue, 3 Nov 2020 08:36:07 +0000 (UTC) X-FDA: 77442449574.27.cap79_25082d8272b7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 03C4B3D669 for ; Tue, 3 Nov 2020 08:36:06 +0000 (UTC) X-HE-Tag: cap79_25082d8272b7 X-Filterd-Recvd-Size: 3024 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 08:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0eIRPF1ESaGV3yiCnvAzM4yO3j7M3IOuEBg1csgujt4=; b=Tz2Yhfv/344RsiHOb8HxBaMlNl kOGsEjdZrvtCXbgMQADGPmx0nxNPRYeoy4Af7kIo7mjroBpSnS2pSzJN6HkEPsnqv/8g4KNYT2mKm 95mueY13d8rpGlNe2N3Y+PMCKph9HPUURR2fucclpVnpOplkRaQN59D8jgP+BNBCpxHWyc8Ik3c8p 9qHYy+5faBzAfQQ0hH4h9Qm5+QM6RxRVFyCwy/9B/tKJBm1w3CJwJATXu3R7mDfvR1JQfc7hWZ3r4 bUYXorE4S/8icfzDu/qr4bWaqngGLOtTPlKxKYYLiX2cNkcXU0T87L53pcPvHz6vbXzu2aBU20MYE YMzVgWMQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZrmv-0002av-88; Tue, 03 Nov 2020 08:35:33 +0000 Date: Tue, 3 Nov 2020 08:35:33 +0000 From: Christoph Hellwig To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Alexander Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Brian Gerst , Christoph Hellwig , Eric Biederman , Ingo Molnar , "H . Peter Anvin" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kexec@lists.infradead.org Subject: Re: [PATCH v2 1/4] kexec: simplify compat_sys_kexec_load Message-ID: <20201103083533.GB9092@infradead.org> References: <20201102123151.2860165-1-arnd@kernel.org> <20201102123151.2860165-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102123151.2860165-2-arnd@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + for (i=0; i < nr_segments; i++) { Missing spaces around the "=". > +SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, > + struct kexec_segment __user *, segments, unsigned long, flags) > +{ > + return kernel_kexec_load(entry, nr_segments, segments, flags); > +} > + > #ifdef CONFIG_COMPAT > COMPAT_SYSCALL_DEFINE4(kexec_load, compat_ulong_t, entry, > compat_ulong_t, nr_segments, > struct compat_kexec_segment __user *, segments, > compat_ulong_t, flags) > { > + return kernel_kexec_load(entry, nr_segments, > + (struct kexec_segment __user *)segments, > + flags); > } I don't think we need sys_compat_kexec_load at all now, all the syscall tables can simply switch to sys_kexec_load for the compat case as well now.