From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CB6C2D0A3 for ; Tue, 3 Nov 2020 15:31:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5C6320735 for ; Tue, 3 Nov 2020 15:31:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C6320735 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44AAC6B0068; Tue, 3 Nov 2020 10:31:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A70B6B006C; Tue, 3 Nov 2020 10:31:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26EDA6B0072; Tue, 3 Nov 2020 10:31:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id ED98A6B0068 for ; Tue, 3 Nov 2020 10:31:22 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8AD73181AC9CC for ; Tue, 3 Nov 2020 15:31:22 +0000 (UTC) X-FDA: 77443496004.01.sort34_180bde0272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id CF4A210047BE5 for ; Tue, 3 Nov 2020 15:31:21 +0000 (UTC) X-HE-Tag: sort34_180bde0272b9 X-Filterd-Recvd-Size: 1518 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 15:31:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C520D6736F; Tue, 3 Nov 2020 16:31:18 +0100 (CET) Date: Tue, 3 Nov 2020 16:31:18 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kent.overstreet@gmail.com Subject: Re: [PATCH 11/17] mm/filemap: Add filemap_range_uptodate Message-ID: <20201103153118.GC10928@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-12-willy@infradead.org> <20201103074944.GK8389@lst.de> <20201103151847.GZ27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103151847.GZ27442@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 03:18:47PM +0000, Matthew Wilcox wrote: > I have a simplification in mind that gets rid of the awkward 'first' > parameter. In filemap_get_pages(), do: > > if ((iocb->ki_flags & IOCB_WAITQ) && (pagevec_count(pvec) > 1)) > iocb->ki_flags |= IOCB_NOWAIT; > > before calling filemap_update_page(). That matches what Kent did in > filemap_read(): Yes, that makes a lot of sense. No need for the second pair of inner braces, though :)