From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0806FC2D0A3 for ; Tue, 3 Nov 2020 15:42:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 692D62080D for ; Tue, 3 Nov 2020 15:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MADYyCRN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 692D62080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97D9C6B005C; Tue, 3 Nov 2020 10:42:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92EB36B005D; Tue, 3 Nov 2020 10:42:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 844316B006C; Tue, 3 Nov 2020 10:42:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 553BE6B005C for ; Tue, 3 Nov 2020 10:42:39 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E58DA180AD802 for ; Tue, 3 Nov 2020 15:42:38 +0000 (UTC) X-FDA: 77443524396.14.cows35_2e044f1272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id C905F18229818 for ; Tue, 3 Nov 2020 15:42:38 +0000 (UTC) X-HE-Tag: cows35_2e044f1272b9 X-Filterd-Recvd-Size: 2506 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 15:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pFgyl3GrEZYaf8JQc2yA1SIpCFCjDU9Ec1IBTDiqJ1I=; b=MADYyCRNOSDjuQi9beNoE1jpa1 IDNFvx9m3rOnrCbVCwj8nlHD34lZaoU2Qnec4eLiQvhTd4jdOnfmnSS6TWJ/WtXN6xE46MWKf8Qyf TnIAKCawD8BHlztZwcatXo0g/2fgT7SNwwGlX4OhdH3XuKJdwi6+Y0/xZACJp7duD7+wHDtctgCq3 1C4yFHLXt2npRFS6Su1MahLcOvUhc0anYNMw1Jm8C/PvBOwcKsxjb9Jvg2S/rmThpYiDyJfB5asLp AIJGmXPv9LqtDcJb8ppbkHzms2Bi4zsAaxtp7yKEriO44oFa3qj9HGpAptBgl04bjHz87qIWUaXVr 2+Hd+c0A==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZyS9-0000C5-Vo; Tue, 03 Nov 2020 15:42:34 +0000 Date: Tue, 3 Nov 2020 15:42:33 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kent.overstreet@gmail.com Subject: Re: [PATCH 11/17] mm/filemap: Add filemap_range_uptodate Message-ID: <20201103154233.GC27442@casper.infradead.org> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-12-willy@infradead.org> <20201103074944.GK8389@lst.de> <20201103151847.GZ27442@casper.infradead.org> <20201103153118.GC10928@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103153118.GC10928@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 04:31:18PM +0100, Christoph Hellwig wrote: > On Tue, Nov 03, 2020 at 03:18:47PM +0000, Matthew Wilcox wrote: > > I have a simplification in mind that gets rid of the awkward 'first' > > parameter. In filemap_get_pages(), do: > > > > if ((iocb->ki_flags & IOCB_WAITQ) && (pagevec_count(pvec) > 1)) > > iocb->ki_flags |= IOCB_NOWAIT; > > > > before calling filemap_update_page(). That matches what Kent did in > > filemap_read(): > > Yes, that makes a lot of sense. No need for the second pair of inner > braces, though :) I wrote it as if ((iocb->ki_flags & IOCB_WAITQ) && pagevec_count(pvec) > 1) originally, and then talked myself into putting the unnecessary brackets in to make it look more symmetric ;-)