From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F323DC388F7 for ; Thu, 5 Nov 2020 19:52:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F9CD20728 for ; Thu, 5 Nov 2020 19:52:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="DnWyN+J6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F9CD20728 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8352F6B0189; Thu, 5 Nov 2020 14:52:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E5576B018A; Thu, 5 Nov 2020 14:52:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 722256B018B; Thu, 5 Nov 2020 14:52:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 473986B0189 for ; Thu, 5 Nov 2020 14:52:38 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D46A6362B for ; Thu, 5 Nov 2020 19:52:37 +0000 (UTC) X-FDA: 77451411954.25.berry56_2301d04272cc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id B22281804E3A0 for ; Thu, 5 Nov 2020 19:52:37 +0000 (UTC) X-HE-Tag: berry56_2301d04272cc X-Filterd-Recvd-Size: 4707 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 19:52:37 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id t5so2018472qtp.2 for ; Thu, 05 Nov 2020 11:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=D3FDe8UgpelV/PGX9SMOeLG5mjEbJxZHhY57CHNG72Q=; b=DnWyN+J6UKOatH9kcqext9yg/T0HnwNvZKOXMY6rrpb1vtwc86xZ7CZ4MzoC97qloL +9yhZueWtt5TtaViz+Gn1A4qJCCnUjyKZp+gjn88/641Ny+dzmIPHvbL5j6QY5karlmC HEcMMGirXcMppiX96wQYSgGtE0a/FdsUVfCka9eDnnJKfN/fMqNZuVQ4Pjp/RQD1GAvD S034unryiLDBDlPxzfL2LnksLN2bECHndaGSymP0yA2bySOXlKN8/d0AEeqnswu+AIR7 sgImnD8TcCdaTDFfcnxCAGx9Xk/odgmlkJR+lAhUb0V17Y1qfHZBK5ckW382x5mvU4Yt ++wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=D3FDe8UgpelV/PGX9SMOeLG5mjEbJxZHhY57CHNG72Q=; b=asQ5j/QRtU506rWZNgyyKETX4cgQ8/5sGkiyhJsyFJmj4zDveC7KmOfYLY4jn2pSjJ LuRjIQwG5xYRFQGwhgkjXgmJ/zb//2DkMh6/rlToGp8o6cSYE331ccGTYn5vVvmblpD1 BXRDGINp4IDMYLR0jS70Kbapxg3//FGTdrhK5PZw81dDbpgTpWP0owCakzuLH/b94t5Y PqO6Hk4DXrhTKQD0qRbbF/Cjp49bHy5llL2Ebw0/8mY9PQbURx65F4isx3BBY9aVG3jP /fHhJx/I6N/5XaOocJZCTZ/q04nHiB8J70uTwp5QSAoQ7wWBDPeryORyVZHMi0HWz7tA DeEQ== X-Gm-Message-State: AOAM530bTVJ4r05CR0YeZuD8IpqRxn65lbxhm1m+Uz9LdQ88/S/cfcOj wf4SxnS6GG0lbVPkBzf5pSpL0Q== X-Google-Smtp-Source: ABdhPJzoo5ik4k55cSFQOg+psdZVvhFwyadZWQMIeDT78AYi13BNFOzssApa4HejRcRx/naX7+eEoQ== X-Received: by 2002:ac8:5ccf:: with SMTP id s15mr3697060qta.375.1604605956558; Thu, 05 Nov 2020 11:52:36 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id r16sm1730106qkm.1.2020.11.05.11.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 11:52:35 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kalJD-000MwV-B2; Thu, 05 Nov 2020 15:52:35 -0400 Date: Thu, 5 Nov 2020 15:52:35 -0400 From: Jason Gunthorpe To: Barry Song Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, John Hubbard , Jan Kara , =?utf-8?B?SsOpcsO0bWU=?= Glisse , "Matthew Wilcox (Oracle)" , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Jonathan Corbet , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka Subject: Re: [PATCH] mm/gup_benchmark: mark gup_benchmark_init as __init function Message-ID: <20201105195235.GI36674@ziepe.ca> References: <20201103081016.16532-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201103081016.16532-1-song.bao.hua@hisilicon.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 09:10:16PM +1300, Barry Song wrote: > gup_benchmark_init() is only called during initialization, mark it as > __init to save some memory. >=20 > Cc: John Hubbard > Cc: Jan Kara > Cc: J=C3=A9r=C3=B4me Glisse > Cc: "Matthew Wilcox (Oracle)" > Cc: Al Viro > Cc: Christoph Hellwig > Cc: Dan Williams > Cc: Dave Chinner > Cc: Jason Gunthorpe > Cc: Jonathan Corbet > Cc: Michal Hocko > Cc: Mike Kravetz > Cc: Shuah Khan > Cc: Vlastimil Babka > Signed-off-by: Barry Song > --- > mm/gup_benchmark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hardly seems worthwhile, but looks correct Reviewed-by: Jason Gunthorpe Jason