From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CA3C2D0A3 for ; Fri, 6 Nov 2020 19:12:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4710420882 for ; Fri, 6 Nov 2020 19:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oJc5q5wr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4710420882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F78C6B0036; Fri, 6 Nov 2020 14:12:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3804E6B005C; Fri, 6 Nov 2020 14:12:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2486B6B005D; Fri, 6 Nov 2020 14:12:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id E270C6B0036 for ; Fri, 6 Nov 2020 14:12:15 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 87F47180AD80F for ; Fri, 6 Nov 2020 19:12:15 +0000 (UTC) X-FDA: 77454939030.26.test81_0a17e84272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 6A03A1804B640 for ; Fri, 6 Nov 2020 19:12:15 +0000 (UTC) X-HE-Tag: test81_0a17e84272d4 X-Filterd-Recvd-Size: 2797 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 19:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XFrYGA+I64WE4jPJawUwvyfheYMv+oPQVkNWu8H/zGo=; b=oJc5q5wruoQ+ALjiLFA+kbjX3G wkRv8BQMjjPhJ0pOmSZLLx/TnXtPpkFtKYwgAMt2O1dMR0OQ64m7tV1xoBuoHSS+W0YAii9Yrp4JQ p9NnZKkUrRw6dWdnP/qFtK1N28lpU62lzZieXJIF9lJMGC1HMnxS6ZT3PVjO6QDFRJK8oalciTbal 1TtYL9U4dEQh9lTsab70K0bT3whTKJR3qoVbjQR676uzd/izYyGOU/IOueJp482I1ZECKyOqUPEen uZwD0Gg8LHtuiLt7tSqtwd6wruS+xevh4ZR7W754IFRLMZOIhiYk2oRYsa+usILl5x7SdcVnqGCkg R2qiTpHw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb79e-0002Eg-JR; Fri, 06 Nov 2020 19:12:10 +0000 Date: Fri, 6 Nov 2020 19:12:10 +0000 From: Matthew Wilcox To: Tim Chen Cc: linux-mm@kvack.org, Jan Kara Subject: Re: [PATCH 1/2] pagevec: Allow pagevecs to be different sizes Message-ID: <20201106191210.GR17076@casper.infradead.org> References: <20201105172651.2455-1-willy@infradead.org> <20201105172651.2455-2-willy@infradead.org> <1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 09:17:43AM -0800, Tim Chen wrote: > > > > > +static inline unsigned pagevec_size(struct pagevec *pvec) > > +{ > > + return pvec->sz; > > +} > > + > > static inline unsigned pagevec_count(struct pagevec *pvec) > > { > > Willy, > > I was expecting pagevec_size to be used in pagevec_lookup_range* > where we hardcoded the pagevec's top range to look for pages > as PAGEVEC_SIZE. You define pagevec_size but seems like it is not used. > Or am I missing something? I have a number of changes already in that area that are currently in-flight. https://lore.kernel.org/linux-mm/20201026041408.25230-1-willy@infradead.org/ (although I should modify patch 9/12 to not use PAGEVEC_SIZE directly) I have some patches that I haven't bothered sending yet since I have so many other outstanding patches to do something similar to find_get_pages() / find_get_pages_range() / pagevec_lookup() / pagevec_lookup_range(). The trace you sent showed the problem being with the lru_add pagevec, and that's never used with the pagevec_lookup_* APIs (afaik), so I didn't see it as urgent to fix those.