Re: [linux-next:master] BUILD REGRESSION 0a6f624a86e766a27d23cbb73c23be62231d10ff

Linus Walleij
2020-11-09T15:54:44Z

On Mon, Nov 9, 2020 at 7:01 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:

> Just build tested this. Observed that set_pud()'s arguments here seems
> to have been reversed. If this looks okay, will send out.

It sure looks good to me.

(It doesn't hurt to have both patches.)

> diff --git a/arch/arm/include/asm/pgtable-2level.h b/arch/arm/include/asm/pgtable-2level.h
> index 3502c2f..9d4f5ee 100644
> --- a/arch/arm/include/asm/pgtable-2level.h
> +++ b/arch/arm/include/asm/pgtable-2level.h
> @@ -177,11 +177,28 @@
> * the pud: the pud entry is never bad, always exists, and can't be set or
> * cleared.
> */
> -#define pud_none(pud) (0)
> -#define pud_bad(pud) (0)
> -#define pud_present(pud) (1)
> -#define pud_clear(pudp) do { } while (0)
> -#define set_pud(pud,pudp) do { } while (0)
> +static inline int pud_none(pud_t pud)
> +{
> + return 0;
> +}
> +
> +static inline int pud_bad(pud_t pud)
> +{
> + return 0;
> +}
> +
> +static inline int pud_present(pud_t pud)
> +{
> + return 1;
> +}
> +
> +static inline void pud_clear(pud_t *pudp)
> +{
> +}
> +
> +static inline void set_pud(pud_t *pudp, pud_t pud)
> +{
> +}

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij