From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E01FC56201 for ; Tue, 10 Nov 2020 18:22:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85DA220797 for ; Tue, 10 Nov 2020 18:22:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85DA220797 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06C456B005D; Tue, 10 Nov 2020 13:22:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F378B6B0068; Tue, 10 Nov 2020 13:22:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E25ED6B006C; Tue, 10 Nov 2020 13:22:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id B1E896B005D for ; Tue, 10 Nov 2020 13:22:25 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 58D34362C for ; Tue, 10 Nov 2020 18:22:25 +0000 (UTC) X-FDA: 77469328650.19.ghost95_0f047a3272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 2B4A21AD1A3 for ; Tue, 10 Nov 2020 18:22:25 +0000 (UTC) X-HE-Tag: ghost95_0f047a3272f7 X-Filterd-Recvd-Size: 1006 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:22:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 876EE68AFE; Tue, 10 Nov 2020 19:22:22 +0100 (CET) Date: Tue, 10 Nov 2020 19:22:22 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v3 11/18] mm/filemap: Convert filemap_update_page to return an errno Message-ID: <20201110182222.GC28701@lst.de> References: <20201110033703.23261-1-willy@infradead.org> <20201110033703.23261-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110033703.23261-12-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000190, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good, Reviewed-by: Christoph Hellwig