From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA16BC55ABD for ; Thu, 12 Nov 2020 19:11:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3ADA82222F for ; Thu, 12 Nov 2020 19:11:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lfgr6Sop" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ADA82222F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 698B76B0036; Thu, 12 Nov 2020 14:11:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 647436B005C; Thu, 12 Nov 2020 14:11:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55D936B0068; Thu, 12 Nov 2020 14:11:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 286106B0036 for ; Thu, 12 Nov 2020 14:11:16 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CBF1D1EF2 for ; Thu, 12 Nov 2020 19:11:15 +0000 (UTC) X-FDA: 77476709310.13.hair83_200027d27308 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id AE2AD18140B70 for ; Thu, 12 Nov 2020 19:11:15 +0000 (UTC) X-HE-Tag: hair83_200027d27308 X-Filterd-Recvd-Size: 2823 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 19:11:15 +0000 (UTC) Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4ED2420B80; Thu, 12 Nov 2020 19:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605208274; bh=MIxnxk8miGxsOAzLOjR0YQwvefMMlSnyIpNObX3bazE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lfgr6SopUO1UFj23PxPDrczZI2Z07mjlkTk9QvecjRTBlADpd716o8if/9yyxRk7g xI2oQQDnwoNGiO63mmwDaugb47yuMbunU88tXUJ5BrXohQVKnTRS/4u2b+FX78WjQq MhLrmrH3jLOtufoFfcYH7BLcpF2br3ZAL0IVCgfQ= Date: Thu, 12 Nov 2020 21:11:05 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Hugh Dickins , Johannes Weiner , Yang Shi , Dave Chinner , linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v3 01/12] mm: Make pagecache tagged lookups return only head pages Message-ID: <20201112191105.GR4758@kernel.org> References: <20201026041408.25230-1-willy@infradead.org> <20201026041408.25230-2-willy@infradead.org> <20201028075056.GB1362354@kernel.org> <20201112174150.GC17076@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112174150.GC17076@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 05:41:50PM +0000, Matthew Wilcox wrote: > On Wed, Oct 28, 2020 at 09:50:56AM +0200, Mike Rapoport wrote: > > > @@ -2074,8 +2074,8 @@ EXPORT_SYMBOL(find_get_pages_contig); > > > * @nr_pages: the maximum number of pages > > > * @pages: where the resulting pages are placed > > > * > > > - * Like find_get_pages, except we only return pages which are tagged with > > > - * @tag. We update @index to index the next page for the traversal. > > > + * Like find_get_pages(), except we only return head pages which are tagged > > > + * with @tag. We update @index to index the next page for the traversal. > > > > Nit: ^ next head page > > I don't love the sentence anyway. How about: > > * Like find_get_pages(), except we only return head pages which are tagged > * with @tag. @index is updated to the index immediately after the last > * page we return, ready for the next iteration. I like it. -- Sincerely yours, Mike.