From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE16C5519F for ; Thu, 12 Nov 2020 21:28:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9305E2224D for ; Thu, 12 Nov 2020 21:27:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="BpevITKR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9305E2224D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3ABFB6B006C; Thu, 12 Nov 2020 16:26:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 360FE6B0072; Thu, 12 Nov 2020 16:26:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 165686B0074; Thu, 12 Nov 2020 16:26:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id CFBFE6B006C for ; Thu, 12 Nov 2020 16:26:54 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 696AE181AEF1A for ; Thu, 12 Nov 2020 21:26:54 +0000 (UTC) X-FDA: 77477051148.19.wound99_2c04e4427309 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 3DA601AD1B0 for ; Thu, 12 Nov 2020 21:26:54 +0000 (UTC) X-HE-Tag: wound99_2c04e4427309 X-Filterd-Recvd-Size: 6090 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 21:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=tg4uf1yPSb1+NPbluHkPZ5qPAwrm/1+z+EzXPXHIqqs=; b=BpevITKRE81lHU4Xrh0y8Vl+OI l9ohsaRmyZrdPCdtUCoOBe8qoUvtnPjPg0YwrQyc85XA2wJyQA5nMkHwzO5rlUXlV8oJ7BR1PJfVv 6k4H+Cm4zf3g4C+q3bPj1HbmAG0cDBKBjmckvuQXrlfbST2of7GNfH/o1rY6RNaGYJubwa+pVlLAa 51PDIqW2AMERRp0fcV8wHfRui3G9Vbn329LRn6xAaB0gHLlxt7dpjf1juQ0Fsf1Q+gN/Zx/1PSe2r duv4Z9ce/IKfCD2psNiIYSq9Fj+z2/o9rChPVFl33LMwOQ01y4pAy1UAD1d4uTGDBTSm4+lGnrHNp m4lgFH8Q==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdK7D-0007H7-Uc; Thu, 12 Nov 2020 21:26:48 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: [PATCH v4 10/16] mm: Add an 'end' parameter to find_get_entries Date: Thu, 12 Nov 2020 21:26:35 +0000 Message-Id: <20201112212641.27837-11-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20201112212641.27837-1-willy@infradead.org> References: <20201112212641.27837-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This simplifies the callers and leads to a more efficient implementation since the XArray has this functionality already. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Jan Kara Reviewed-by: William Kucharski --- include/linux/pagemap.h | 4 ++-- mm/filemap.c | 9 +++++---- mm/shmem.c | 10 ++-------- mm/swap.c | 2 +- 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 9f1f4ab9612a..c7c26a902743 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -449,8 +449,8 @@ static inline struct page *find_subpage(struct page *= head, pgoff_t index) } =20 unsigned find_get_entries(struct address_space *mapping, pgoff_t start, - unsigned int nr_entries, struct page **entries, - pgoff_t *indices); + pgoff_t end, unsigned int nr_entries, struct page **entries, + pgoff_t *indices); unsigned find_get_pages_range(struct address_space *mapping, pgoff_t *st= art, pgoff_t end, unsigned int nr_pages, struct page **pages); diff --git a/mm/filemap.c b/mm/filemap.c index f18c5074865d..b3b89a62ab1a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1870,6 +1870,7 @@ static inline struct page *find_get_entry(struct xa= _state *xas, pgoff_t max, * find_get_entries - gang pagecache lookup * @mapping: The address_space to search * @start: The starting page cache index + * @end: The final page index (inclusive). * @nr_entries: The maximum number of entries * @entries: Where the resulting entries are placed * @indices: The cache indices corresponding to the entries in @entries @@ -1893,9 +1894,9 @@ static inline struct page *find_get_entry(struct xa= _state *xas, pgoff_t max, * * Return: the number of pages and shadow entries which were found. */ -unsigned find_get_entries(struct address_space *mapping, - pgoff_t start, unsigned int nr_entries, - struct page **entries, pgoff_t *indices) +unsigned find_get_entries(struct address_space *mapping, pgoff_t start, + pgoff_t end, unsigned int nr_entries, struct page **entries, + pgoff_t *indices) { XA_STATE(xas, &mapping->i_pages, start); struct page *page; @@ -1905,7 +1906,7 @@ unsigned find_get_entries(struct address_space *map= ping, return 0; =20 rcu_read_lock(); - while ((page =3D find_get_entry(&xas, ULONG_MAX, XA_PRESENT))) { + while ((page =3D find_get_entry(&xas, end, XA_PRESENT))) { /* * Terminate early on finding a THP, to allow the caller to * handle it all at once; but continue if this is hugetlbfs. diff --git a/mm/shmem.c b/mm/shmem.c index a4aa762a55f8..7a62dc967d7d 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -913,8 +913,6 @@ static void shmem_undo_range(struct inode *inode, lof= f_t lstart, loff_t lend, struct page *page =3D pvec.pages[i]; =20 index =3D indices[i]; - if (index >=3D end) - break; =20 if (xa_is_value(page)) { if (unfalloc) @@ -967,9 +965,8 @@ static void shmem_undo_range(struct inode *inode, lof= f_t lstart, loff_t lend, while (index < end) { cond_resched(); =20 - pvec.nr =3D find_get_entries(mapping, index, - min(end - index, (pgoff_t)PAGEVEC_SIZE), - pvec.pages, indices); + pvec.nr =3D find_get_entries(mapping, index, end - 1, + PAGEVEC_SIZE, pvec.pages, indices); if (!pvec.nr) { /* If all gone or hole-punch or unfalloc, we're done */ if (index =3D=3D start || end !=3D -1) @@ -982,9 +979,6 @@ static void shmem_undo_range(struct inode *inode, lof= f_t lstart, loff_t lend, struct page *page =3D pvec.pages[i]; =20 index =3D indices[i]; - if (index >=3D end) - break; - if (xa_is_value(page)) { if (unfalloc) continue; diff --git a/mm/swap.c b/mm/swap.c index 29220174433b..39be55635ebd 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -1102,7 +1102,7 @@ unsigned pagevec_lookup_entries(struct pagevec *pve= c, pgoff_t start, unsigned nr_entries, pgoff_t *indices) { - pvec->nr =3D find_get_entries(mapping, start, nr_entries, + pvec->nr =3D find_get_entries(mapping, start, ULONG_MAX, nr_entries, pvec->pages, indices); return pagevec_count(pvec); } --=20 2.28.0