From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B36C56202 for ; Thu, 12 Nov 2020 21:27:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64E7E2224F for ; Thu, 12 Nov 2020 21:27:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="a9Dldi9i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E7E2224F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C10DF6B007D; Thu, 12 Nov 2020 16:26:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B436B007E; Thu, 12 Nov 2020 16:26:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A679E6B0080; Thu, 12 Nov 2020 16:26:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 65C336B007D for ; Thu, 12 Nov 2020 16:26:58 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 17229180AD804 for ; Thu, 12 Nov 2020 21:26:58 +0000 (UTC) X-FDA: 77477051316.07.heat73_4a0062427309 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id F129E1803F9A1 for ; Thu, 12 Nov 2020 21:26:57 +0000 (UTC) X-HE-Tag: heat73_4a0062427309 X-Filterd-Recvd-Size: 2454 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 21:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=w06ZP8J1L1sNnrL6d7bu/K2RwiChw8umB6NkZXCjOJM=; b=a9Dldi9iEA7FsD03s2jU9jo1jw DCu12xlb5XFWmxWtgbqZO4LCcIUcnPn2cAeWN/YBHpH4yuWcCl3xgOxosVLAev/3+F+Oj2gZBcC2J +yWjYaqWuopWkvwOP7IPzWAznGyc1hWUmCXD1cIyIQ0plBCNNy3Mk1Rcj6F9GF0yQH+wiNOZTaFKE N2oR/gMEzTOCXt80wJZ1HPQyWkHSO1BrpcvUXkSGwHSQvsSUwXulC72JphaN3rocSWx3TGiT8UZlm 3gIQITyu4v+ifFvLr06G9cgYZ6Nrui1twyBnSOEFKIFiBHLqiELYE06q6lzb3KIJVPzCybJYqrWo3 Wv0E/QQA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdK7A-0007GF-Qj; Thu, 12 Nov 2020 21:26:44 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/16] mm/swap: Optimise get_shadow_from_swap_cache Date: Thu, 12 Nov 2020 21:26:28 +0000 Message-Id: <20201112212641.27837-4-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20201112212641.27837-1-willy@infradead.org> References: <20201112212641.27837-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There's no need to get a reference to the page, just load the entry and see if it's a shadow entry. Signed-off-by: Matthew Wilcox (Oracle) --- mm/swap_state.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/swap_state.c b/mm/swap_state.c index cf7b322a9abc..d2161154d873 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -113,11 +113,9 @@ void *get_shadow_from_swap_cache(swp_entry_t entry) pgoff_t idx =3D swp_offset(entry); struct page *page; =20 - page =3D find_get_entry(address_space, idx); + page =3D xa_load(&address_space->i_pages, idx); if (xa_is_value(page)) return page; - if (page) - put_page(page); return NULL; } =20 --=20 2.28.0