From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB85C5519F for ; Sat, 14 Nov 2020 05:48:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0705320A8B for ; Sat, 14 Nov 2020 05:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="QkHRXbqe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0705320A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36F886B005C; Sat, 14 Nov 2020 00:48:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31FF16B005D; Sat, 14 Nov 2020 00:48:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20E696B0068; Sat, 14 Nov 2020 00:48:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id E7DE16B005C for ; Sat, 14 Nov 2020 00:48:18 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8B9318249980 for ; Sat, 14 Nov 2020 05:48:18 +0000 (UTC) X-FDA: 77481943476.13.waste92_271162d27315 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 5BD6518140B67 for ; Sat, 14 Nov 2020 05:48:18 +0000 (UTC) X-HE-Tag: waste92_271162d27315 X-Filterd-Recvd-Size: 5835 Received: from m12-16.163.com (m12-16.163.com [220.181.12.16]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 05:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=Yf5KW EBlfPvY8UckWvudcwjucfSNaBU4AKahUmFqssw=; b=QkHRXbqeoYY95xp26u3pf f+eSoD1rIVspusLI0lxyGE00YcNkiV2TCLxg+cY6rK9i7KCujTOHTB+hNW0eHyaE 88aNwDmTb86csVZSiRXhekOJOi8em5KLBEdW1/DQD0CHKmkhv/l5+T3htNj+GWVu WFlyaAIQ5wgvUSJPCtbYY8= Received: from localhost (unknown [101.86.213.176]) by smtp12 (Coremail) with SMTP id EMCowACXRmOOb69f3D00Lw--.16686S2; Sat, 14 Nov 2020 13:47:58 +0800 (CST) Date: Sat, 14 Nov 2020 13:47:58 +0800 From: Hui Su To: kernel test robot , hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: Re: [PATCH] mm/shmem.c: make shmem_mapping() inline Message-ID: <20201114054758.GA185928@rlk> References: <20201113135427.GA167783@rlk> <202011140010.ETcSkyze-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202011140010.ETcSkyze-lkp@intel.com> X-CM-TRANSID:EMCowACXRmOOb69f3D00Lw--.16686S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxCrykCF48Jw4rZF15Gr4fGrg_yoWrWry7pa 4qyw1UKrs5JrW0vFWxZay0v34Yqrs5Jry8tFyfGr9IyF1qqry7KwsIkFyY9ryYkrWkWay2 vFyUG3sY9w4UJ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UqApOUUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiWQ-cX1WBtZx2uwAAsl X-Bogosity: Ham, tests=bogofilter, spamicity=0.001611, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 14, 2020 at 12:54:47AM +0800, kernel test robot wrote: > Hi Hui, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on mmotm/master] > > url: https://github.com/0day-ci/linux/commits/Hui-Su/mm-shmem-c-make-shmem_mapping-inline/20201113-215549 > base: git://git.cmpxchg.org/linux-mmotm.git master > config: arm-randconfig-s032-20201113 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-107-gaf3512a6-dirty > # https://github.com/0day-ci/linux/commit/0434762d5523a3d702cd589a7f8e3771fee7b3b2 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Hui-Su/mm-shmem-c-make-shmem_mapping-inline/20201113-215549 > git checkout 0434762d5523a3d702cd589a7f8e3771fee7b3b2 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > "sparse warnings: (new ones prefixed by >>)" > mm/filemap.c: note: in included file: > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > -- > mm/truncate.c: note: in included file: > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > -- > mm/memfd.c: note: in included file: > >> include/linux/shmem_fs.h:66:33: sparse: sparse: marked inline, but without a definition > > vim +66 include/linux/shmem_fs.h > > 48 > 49 /* > 50 * Functions in mm/shmem.c called directly from elsewhere: > 51 */ > 52 extern const struct fs_parameter_description shmem_fs_parameters; > 53 extern int shmem_init(void); > 54 extern int shmem_init_fs_context(struct fs_context *fc); > 55 extern struct file *shmem_file_setup(const char *name, > 56 loff_t size, unsigned long flags); > 57 extern struct file *shmem_kernel_file_setup(const char *name, loff_t size, > 58 unsigned long flags); > 59 extern struct file *shmem_file_setup_with_mnt(struct vfsmount *mnt, > 60 const char *name, loff_t size, unsigned long flags); > 61 extern int shmem_zero_setup(struct vm_area_struct *); > 62 extern unsigned long shmem_get_unmapped_area(struct file *, unsigned long addr, > 63 unsigned long len, unsigned long pgoff, unsigned long flags); > 64 extern int shmem_lock(struct file *file, int lock, struct user_struct *user); > 65 #ifdef CONFIG_SHMEM > > 66 extern inline bool shmem_mapping(struct address_space *mapping); > 67 #else > 68 static inline bool shmem_mapping(struct address_space *mapping) > 69 { > 70 return false; > 71 } > 72 #endif /* CONFIG_SHMEM */ > 73 extern void shmem_unlock_mapping(struct address_space *mapping); > 74 extern struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > 75 pgoff_t index, gfp_t gfp_mask); > 76 extern void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end); > 77 extern int shmem_unuse(unsigned int type, bool frontswap, > 78 unsigned long *fs_pages_to_unuse); > 79 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Thanks for your test. I will resend a PATCH V2 later.