From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D91DC2D0E4 for ; Tue, 17 Nov 2020 13:56:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52CC520706 for ; Tue, 17 Nov 2020 13:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rvxkhDnm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52CC520706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74AD06B0073; Tue, 17 Nov 2020 08:56:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FBD46B0074; Tue, 17 Nov 2020 08:56:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59D006B0075; Tue, 17 Nov 2020 08:56:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 2963A6B0073 for ; Tue, 17 Nov 2020 08:56:43 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C53AE180AD81D for ; Tue, 17 Nov 2020 13:56:42 +0000 (UTC) X-FDA: 77494060644.04.chain23_1207aeb27332 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id A3A318007DC3 for ; Tue, 17 Nov 2020 13:56:42 +0000 (UTC) X-HE-Tag: chain23_1207aeb27332 X-Filterd-Recvd-Size: 2477 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 13:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E24uSWfoTl4Cofu3qQrfxUps4G3LuyBx4MqJTQyuhJA=; b=rvxkhDnmXgjJbSa0RuhPokJurG 4hj1wuzM6npD+VT1WBhyXi5yfWDwjljSh+RudYdsVi6dDwzKgRF68oomM8b+EL/c1Wts9xTk3stdm X+pYUQkf7P75emWj2l0M3stykyOof+6vx13/6SKZJlt8JxGH8laobVtcD4/FFEnnKPAJd0FWMxGHP bf0pKMf4pOfzkTcIbhm698q7Rdo4KZzXW8PTtwcUtRB53mUM84AH88jTP83QglTSLVMql8iiGsp5d 1LuGwqCN3CF6i5dM3TKHWbwErVu+OJI5O4IQ7ztRsQ6k2rTl0hA5c/tuoi7ln0XoQ95AhfLQZP7sF I5tw4Tfw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf1TE-0007V6-Mi; Tue, 17 Nov 2020 13:56:32 +0000 Date: Tue, 17 Nov 2020 13:56:32 +0000 From: Christoph Hellwig To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm , "Aneesh Kumar K . V" , Harish Sriram , stable@vger.kernel.org Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Message-ID: <20201117135632.GA27763@infradead.org> References: <20201105170249.387069-1-minchan@kernel.org> <20201106175933.90e4c8851010c9ce4dd732b6@linux-foundation.org> <20201107083939.GA1633068@google.com> <20201112200101.GC123036@google.com> <20201112144919.5f6b36876f4e59ebb4a99d6d@linux-foundation.org> <20201113162529.GA2378542@google.com> <20201116175323.GB3805951@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116175323.GB3805951@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Btw, I remember that the whole vmalloc magic in zsmalloc was only giving a small benefit for a few niche use cases. Given that it generally has very strange interaction with the vmalloc core, including using various APIs not used by any driver I'm going to ask once again why we can't just drop the CONFIG_ZSMALLOC_PGTABLE_MAPPING case entirely?