From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3A4C2D0E4 for ; Tue, 17 Nov 2020 15:32:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA16424655 for ; Tue, 17 Nov 2020 15:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="V9sb2iZ0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA16424655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F20A86B0070; Tue, 17 Nov 2020 10:32:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAAC46B0072; Tue, 17 Nov 2020 10:32:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D71FA6B0073; Tue, 17 Nov 2020 10:32:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id A527D6B0070 for ; Tue, 17 Nov 2020 10:32:43 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4E181181AEF00 for ; Tue, 17 Nov 2020 15:32:43 +0000 (UTC) X-FDA: 77494302606.05.board14_0116a2927332 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 34C7318001755 for ; Tue, 17 Nov 2020 15:32:43 +0000 (UTC) X-HE-Tag: board14_0116a2927332 X-Filterd-Recvd-Size: 3680 Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 15:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=QXb/z g1X4H1k8Xsn4vadPNzXgtECSKbY8Ay5LD6piDE=; b=V9sb2iZ0eNiRjSsdrgUVj Z5SQETLe1/Sa8fwSdcsUTXWW7i4wKsqwzYEeGU+C1LH/sSHDYLUMgV/jVZACgmms rAUJ5OO+2rEbf/PR0Hx/xj2Tu4cCUWX7OS0MxBNHg/KXNlH0ThgJzicUvvQUiffL iSq8X+heQ+nz0mbNwnEycc= Received: from localhost (unknown [101.86.213.176]) by smtp8 (Coremail) with SMTP id DMCowABXe+zU7LNf+Ef_CA--.52617S2; Tue, 17 Nov 2020 23:31:32 +0800 (CST) Date: Tue, 17 Nov 2020 23:31:32 +0800 From: Hui Su To: Stephen Rothwell , hughd@google.com Cc: Andrew Morton , mm-commits@vger.kernel.org, sh_def@163.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: + mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch added to -mm tree Message-ID: <20201117153132.GA4153@rlk> References: <20201116230526.NkEfmeDCH%akpm@linux-foundation.org> <20201117181246.5f29f9ca@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117181246.5f29f9ca@canb.auug.org.au> X-CM-TRANSID:DMCowABXe+zU7LNf+Ef_CA--.52617S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7AF48Gr1Duw4rXF1fKryrXrb_yoW8AF4xpF WfGFsxta1DJryxGryxK3Z2qr109rWftrWjqFy5Jw18ZFn5ZF1DKr4vkr1rWF95CFyrGF1j vF4UWr1xur4UAaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zMCJm9UUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiMRTfX1UMWYUOOgAAsU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 06:12:46PM +1100, Stephen Rothwell wrote: > Hi Hugh, > > On Mon, 16 Nov 2020 22:17:20 -0800 (PST) Hugh Dickins wrote: > > > > On Mon, 16 Nov 2020, akpm@linux-foundation.org wrote: > > > > > > The patch titled > > > Subject: mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode() > > > has been added to the -mm tree. Its filename is > > > mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch > > > > > > This patch should soon appear at > > > https://ozlabs.org/~akpm/mmots/broken-out/mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch > > > and later at > > > https://ozlabs.org/~akpm/mmotm/broken-out/mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch > > > > > > Before you just go and hit "reply", please: > > > a) Consider who else should be cc'ed > > > b) Prefer to cc a suitable mailing list as well > > > c) Ideally: find the original patch on the mailing list and do a > > > reply-to-all to that, adding suitable additional cc's > > > > > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > > > > > The -mm tree is included into linux-next and is updated > > > there every 3-4 working days > > > > > > ------------------------------------------------------ > > > From: Hui Su > > > Subject: mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode() > > > > Andrew, Stephen, please revert this untested "cleanup" from your > > trees a.s.a.p: it's a disaster for anyone using shmem/tmpfs. > > Thanks for that. I have also bisected my boot failures to that commit > and so have reverted it from linux-next today. > > -- > Cheers, > Stephen Rothwell Sorry for not full testing the change. Please ignore this change. Thanks.