From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079D6C5519F for ; Tue, 17 Nov 2020 17:40:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4ACEF24654 for ; Tue, 17 Nov 2020 17:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="n/wGVSYG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ACEF24654 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53B296B0036; Tue, 17 Nov 2020 12:40:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9FB6B005C; Tue, 17 Nov 2020 12:40:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EF9A6B0071; Tue, 17 Nov 2020 12:40:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id F0F196B0036 for ; Tue, 17 Nov 2020 12:40:48 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 90AF7362B for ; Tue, 17 Nov 2020 17:40:48 +0000 (UTC) X-FDA: 77494625376.25.anger78_4d1855a27333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 7DCA81804E3AD for ; Tue, 17 Nov 2020 17:40:47 +0000 (UTC) X-HE-Tag: anger78_4d1855a27333 X-Filterd-Recvd-Size: 1769 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 17:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ViLhUA4I08HwLcRLKTVqoaxN2XTRXddkPrqS8u4JVe8=; b=n/wGVSYG+i1gtrLPGWWPkW91mP NDgz82iPzYPOA4Q+ALWIVCmMdmhS9cx9/h9DWeDjwD/mLeeVms1Ib9MybL+aVC0jjM60c3sc08GzK cB7SNP1YIbl71uaH5MDOc9jTXb3UT0++LyyfdhUCYasUo+kiqEZtvJc+UvYXLG7xZKse53E8TlKiG SuM/b2zJFJhWLmRU7jMc23mwJWcCbj54LaC3HQwjJpOaNERM9IxqzyjIyYbzY9Vm1YMGc3HHkdCM7 54P+LQNfyT6VETbWEkvx1KVlsqbQht4L8/vXbJ8SwYVJ9bKKYM4rdyqHHN8ny2scGZqM9voNp6FY2 Q8KlGirA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf4y9-0006kF-8h; Tue, 17 Nov 2020 17:40:41 +0000 Date: Tue, 17 Nov 2020 17:40:41 +0000 From: Matthew Wilcox To: Hui Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117174041.GP29991@casper.infradead.org> References: <20201117164919.GA82821@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117164919.GA82821@rlk> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 12:49:19AM +0800, Hui Su wrote: > page->lru bit 0 can tell whether the page is > avtive page or not. > page->lru bit 1 can tell whether the page is > file page or not. This is wrong. I'll let you figure out why.