From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48437C5519F for ; Tue, 17 Nov 2020 17:41:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 96F4D206B6 for ; Tue, 17 Nov 2020 17:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ly0DsO0O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F4D206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 11AF86B005C; Tue, 17 Nov 2020 12:41:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A5156B0071; Tue, 17 Nov 2020 12:41:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFC5F6B0072; Tue, 17 Nov 2020 12:41:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id BF97A6B005C for ; Tue, 17 Nov 2020 12:41:20 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4B496362B for ; Tue, 17 Nov 2020 17:41:20 +0000 (UTC) X-FDA: 77494626720.18.chess78_0d118e127333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 21BE6100ED0E0 for ; Tue, 17 Nov 2020 17:41:20 +0000 (UTC) X-HE-Tag: chess78_0d118e127333 X-Filterd-Recvd-Size: 1913 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 17:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pmBYhBP5We7GHGzGu7owER3LNkD4Ikjk91kiljzGJ1A=; b=Ly0DsO0Od8hd/O0w73TWUTZ4OL KLc9lwwwMr/shGjFc79zunjo56JgO3xLEIUrfL3/V4hb2roYpW/MwSYmqkfWnyzS3v4YlTxLEDU+h PL50OnLgRzvoDo3wk34eVivQ2J0aaUxJQ4xkRpbBrLEhlAKApI+7lkyf+xMQABT8eEocrf1mzNlEt cfRrtlLM/D1tFbBP87Pk7CTHGCCqoNAmgyLWaZT2Lmd/qqI2RRj29hib8Lk6UizBvbG2KmP+xVaBM zA34VcYBEmorDo4fOsmkjB2jxEOhJQTavW3wEMOsvY9iP4w4p8DCXdL307hr32yGFJ+QY8NJTqadK 3p8QLkuw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf4yj-0006oy-DL; Tue, 17 Nov 2020 17:41:17 +0000 Date: Tue, 17 Nov 2020 17:41:17 +0000 From: Matthew Wilcox To: Hui Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117174117.GQ29991@casper.infradead.org> References: <20201117171242.GA120587@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117171242.GA120587@rlk> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > lru_list lru bit 0 can tell whether the list is > avtive lru-list or not. > lru_list lru bit 1 can tell whether the list is > file lru-list or not. > > And fix some define type in shrink_active_list() > and get_scan_count(). > > v1->v2: > correct the commit message, and fix the define type. No, still incorrect.