From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D80DC2D0E4 for ; Tue, 17 Nov 2020 17:46:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FB7F2465E for ; Tue, 17 Nov 2020 17:46:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ghx63B/Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB7F2465E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A15326B0075; Tue, 17 Nov 2020 12:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99D686B0078; Tue, 17 Nov 2020 12:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866346B007B; Tue, 17 Nov 2020 12:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 561446B0075 for ; Tue, 17 Nov 2020 12:46:52 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F1DFD180AD81F for ; Tue, 17 Nov 2020 17:46:51 +0000 (UTC) X-FDA: 77494640622.08.page39_3715c0027333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id D05021819E785 for ; Tue, 17 Nov 2020 17:46:51 +0000 (UTC) X-HE-Tag: page39_3715c0027333 X-Filterd-Recvd-Size: 2074 Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 17:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=PF7Fm nWexI8aUiHza1IDKXIAbnpRAZGxrXIeRXk7E0U=; b=ghx63B/Y9rEaMyKSR/t6U sjcEEi9J0xsSWhN1ZOAV12NiJHA4+V/v0svrOnJ9E2rdxBckjWpkj9BI2f3/GVgK kIFVnvCnLMT0xRH7c040CpizFQXPm1p3B3Cs1X53WGUhHK+OXf/CXJhOgqhivwXD VWmlFRUhHb12D5PATSVJJs= Received: from localhost (unknown [101.86.213.141]) by smtp9 (Coremail) with SMTP id DcCowADHZkt5DLRfqKjbRA--.42929S2; Wed, 18 Nov 2020 01:46:33 +0800 (CST) Date: Wed, 18 Nov 2020 01:46:33 +0800 From: Hui Su To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117174633.GA158014@rlk> References: <20201117171242.GA120587@rlk> <20201117174117.GQ29991@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117174117.GQ29991@casper.infradead.org> X-CM-TRANSID:DcCowADHZkt5DLRfqKjbRA--.42929S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUrZ2TUUUUU X-Originating-IP: [101.86.213.141] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiWRnfX1WBtcWFFgAAs3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.411843, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > > lru_list lru bit 0 can tell whether the list is > > avtive lru-list or not. > > lru_list lru bit 1 can tell whether the list is > > file lru-list or not. > > > > And fix some define type in shrink_active_list() > > and get_scan_count(). > > > > v1->v2: > > correct the commit message, and fix the define type. > > No, still incorrect. I am a little confused, can you tell in detail? Thanks.