From: Matthew Wilcox <willy@infradead.org>
To: Hui Su <sh_def@163.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()
Date: Tue, 17 Nov 2020 17:47:27 +0000 [thread overview]
Message-ID: <20201117174727.GR29991@casper.infradead.org> (raw)
In-Reply-To: <20201117174633.GA158014@rlk>
On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote:
> On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote:
> > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote:
> > > lru_list lru bit 0 can tell whether the list is
> > > avtive lru-list or not.
> > > lru_list lru bit 1 can tell whether the list is
> > > file lru-list or not.
> > >
> > > And fix some define type in shrink_active_list()
> > > and get_scan_count().
> > >
> > > v1->v2:
> > > correct the commit message, and fix the define type.
> >
> > No, still incorrect.
>
> I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of
tests on it?
next prev parent reply other threads:[~2020-11-17 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:12 [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Hui Su
2020-11-17 17:41 ` Matthew Wilcox
2020-11-17 17:46 ` Hui Su
2020-11-17 17:47 ` Matthew Wilcox [this message]
2020-11-17 17:56 ` Hui Su
2020-11-17 17:59 ` Matthew Wilcox
2020-11-17 18:05 ` Hui Su
2020-11-20 19:08 ` Hui Su
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 16:49 Hui Su
2020-11-17 16:53 ` Hui Su
2020-11-17 17:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117174727.GR29991@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).