From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0ABC2D0E4 for ; Tue, 17 Nov 2020 17:47:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0858E21734 for ; Tue, 17 Nov 2020 17:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UeoIWr+C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0858E21734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50B3A6B0078; Tue, 17 Nov 2020 12:47:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4935F6B007B; Tue, 17 Nov 2020 12:47:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35BE66B007D; Tue, 17 Nov 2020 12:47:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 00AB36B0078 for ; Tue, 17 Nov 2020 12:47:30 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 91044362B for ; Tue, 17 Nov 2020 17:47:30 +0000 (UTC) X-FDA: 77494642260.03.coach50_0d0719027333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 70ABB28A4EB for ; Tue, 17 Nov 2020 17:47:30 +0000 (UTC) X-HE-Tag: coach50_0d0719027333 X-Filterd-Recvd-Size: 2310 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 17:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LoYIqtE2uArlhd3t+oFaPxRtBOcfWW3ruKCeiAsN3WI=; b=UeoIWr+Cys8QMHfERbA/soqOj/ xKMiowp3J7R140jplcIf1kcvU4zmPDfT3qGz75OYGOrh97GbZiEzJ7rU4wVGMCJZ642YMONhtbr14 F/RCDd4o7wglwECBtGx0QjwKyvxJ0KHiNfBZ5I5NsKLAp9++LAnnQi3swbVsrerj2VkL5QF5U//GC LmflvnKqQcOrR4F1+E5yrniSDDbOrdQBw86Ph4/7T3SYLJ2OcwmzcBoO1EAPJ3bJYX+Ex8qbLBF5S we1p7YEmG+rgthuRTml0UFUOaPTMvZO5B8rx5TlvS+UACGCktojNyooAeCRDqubnqX74dTM83fiaC gVUe+AiA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf54h-0007Bf-6H; Tue, 17 Nov 2020 17:47:27 +0000 Date: Tue, 17 Nov 2020 17:47:27 +0000 From: Matthew Wilcox To: Hui Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117174727.GR29991@casper.infradead.org> References: <20201117171242.GA120587@rlk> <20201117174117.GQ29991@casper.infradead.org> <20201117174633.GA158014@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117174633.GA158014@rlk> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote: > On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote: > > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > > > lru_list lru bit 0 can tell whether the list is > > > avtive lru-list or not. > > > lru_list lru bit 1 can tell whether the list is > > > file lru-list or not. > > > > > > And fix some define type in shrink_active_list() > > > and get_scan_count(). > > > > > > v1->v2: > > > correct the commit message, and fix the define type. > > > > No, still incorrect. > > I am a little confused, can you tell in detail? Have you booted a kernel with this change? Have you run any kind of tests on it?