From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04548C2D0E4 for ; Tue, 17 Nov 2020 23:43:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEC5F24248 for ; Tue, 17 Nov 2020 23:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Omh9HHcu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEC5F24248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25B416B006C; Tue, 17 Nov 2020 18:43:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20BF76B0070; Tue, 17 Nov 2020 18:43:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1217E6B0071; Tue, 17 Nov 2020 18:43:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id D8F196B006C for ; Tue, 17 Nov 2020 18:43:12 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7C53E8249980 for ; Tue, 17 Nov 2020 23:43:12 +0000 (UTC) X-FDA: 77495538624.17.seed17_2e1593627335 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 5F685180D0181 for ; Tue, 17 Nov 2020 23:43:12 +0000 (UTC) X-HE-Tag: seed17_2e1593627335 X-Filterd-Recvd-Size: 2204 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 23:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7YHR2e1/LHdcwbDfdQHbOVb5eFvzBWcfcNYNhAMGlwc=; b=Omh9HHcudW9qg6FCeuzA3BMnTT WSKVlVHr8w8CYJdKkd+A42tomHgdm/10sLe2wCJaVvNA24LQR5ORrq5zbBso2mhk0Hh7ZioA9QB1+ cU7h2Y+dRQwcgIzGN42g27nSA5eUpoglHxgDRKuEKdXXa3WoWesnP1B3qzWVi+ZCBXSuk4VYDWlZb Wi57htRt0aTL+bxJfFbUxYOBB1RuMpTSUy6pAxSfRLUy9R2nNfsymiyp/aNear1MjdJP8VFTMF5aV 1stbt+FhLGfRTVrWaeSZ2E/3jrxzN5IW15XYmCpWW04jet7hBK5TW7rFciFenQOAOTUViNLVCLcC2 PG/I7chw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfAco-000461-8J; Tue, 17 Nov 2020 23:43:02 +0000 Date: Tue, 17 Nov 2020 23:43:02 +0000 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP Message-ID: <20201117234302.GC29991@casper.infradead.org> References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117191513.GV29991@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: > I find both of these functions exceptionally confusing. Does this > make it easier to understand? Never mind, this is buggy. I'll send something better tomorrow.