From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FB4C388F9 for ; Thu, 19 Nov 2020 07:52:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56B77246D4 for ; Thu, 19 Nov 2020 07:52:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56B77246D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E3D76B005C; Thu, 19 Nov 2020 02:52:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BE786B005D; Thu, 19 Nov 2020 02:52:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AB1F6B0068; Thu, 19 Nov 2020 02:52:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 4D0BE6B005C for ; Thu, 19 Nov 2020 02:52:31 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E98C48249980 for ; Thu, 19 Nov 2020 07:52:30 +0000 (UTC) X-FDA: 77500400460.09.lunch56_1a0afcc27341 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id D327D180AD822 for ; Thu, 19 Nov 2020 07:52:30 +0000 (UTC) X-HE-Tag: lunch56_1a0afcc27341 X-Filterd-Recvd-Size: 2022 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Nov 2020 07:52:30 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id E541867373; Thu, 19 Nov 2020 08:52:25 +0100 (CET) Date: Thu, 19 Nov 2020 08:52:25 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/20] init: refactor name_to_dev_t Message-ID: <20201119075225.GA15815@lst.de> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-8-hch@lst.de> <20201118143747.GL1981@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118143747.GL1981@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 03:37:47PM +0100, Jan Kara wrote: > > -static inline dev_t blk_lookup_devt(const char *name, int partno) > > -{ > > - dev_t devt = MKDEV(0, 0); > > - return devt; > > -} > > #endif /* CONFIG_BLOCK */ > > This hunk looks unrelated to the change? Also why you move the declaration > outside the CONFIG_BLOCK ifdef? AFAICS blk_lookup_devt() still exists only > when CONFIG_BLOCK is defined? Otherwise the patch looks good to me. blk_lookup_devt is a hack only for name_to_dev_t only referenced from code under CONFIG_BLOCK now, as it didn't do anything before when blk_lookup_devt returned 0. I guess I'll need to update the commit log a little to mention this.