From: Hui Su <sh_def@163.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()
Date: Sat, 21 Nov 2020 03:08:52 +0800 [thread overview]
Message-ID: <20201120190852.GA19256@rlk> (raw)
In-Reply-To: <20201117175900.GS29991@casper.infradead.org>
On Tue, Nov 17, 2020 at 05:59:00PM +0000, Matthew Wilcox wrote:
> On Wed, Nov 18, 2020 at 01:56:58AM +0800, Hui Su wrote:
> > On Tue, Nov 17, 2020 at 05:47:27PM +0000, Matthew Wilcox wrote:
> > > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote:
> > > > On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote:
> > > > > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote:
> > > > > > lru_list lru bit 0 can tell whether the list is
> > > > > > avtive lru-list or not.
> > > > > > lru_list lru bit 1 can tell whether the list is
> > > > > > file lru-list or not.
> > > > > >
> > > > > > And fix some define type in shrink_active_list()
> > > > > > and get_scan_count().
> > > > > >
> > > > > > v1->v2:
> > > > > > correct the commit message, and fix the define type.
> > > > >
> > > > > No, still incorrect.
> > > >
> > > > I am a little confused, can you tell in detail?
> > >
> > > Have you booted a kernel with this change? Have you run any kind of
> > > tests on it?
> >
> > Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
> > qemu-system-x86_64 -kernel /home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage -hda \
> > /home/rlk/myspace/qemu_build/rootfs.img -append "root=/dev/sda console=ttyS0" -nographic
> >
> > using the kernel compiled with ubuntu20.04's default .config.
> >
> > It seems nothing abnormal.
> > And i did not do other test.
>
> Maybe you should ... how about LTP? I think that's pretty straightforward
> to set up and run.
Hi Matthew:
Thanks for your advice, i finally setup a test platform powered by
jenkins and QEMU emulator version 4.2.1 with two evening. This is
the things that i always wanted to do but didn't do.
I apply this change based on the commit: 4d02da974ea8, and compile
it with x86_64_defconfig:
make bzImage O=/var/lib/jenkins/workspace/linux_kernel_ltp/out/
Then start qemu:
sudo qemu-system-x86_64 \
-kernel /var/lib/jenkins/workspace/linux_kernel_ltp/out/arch/x86/boot/bzImage \
-hda /home/ubuntu/myspace/qemu_build/ubuntu.img \
-hdb /home/ubuntu/myspace/qemu_build/init.img \
-append "root=/dev/sda console=ttyS0" \
-nographic \
-m 1024 \
-fsdev local,id=fs1,path=/home/ubuntu/workspace,security_model=none \
-device virtio-9p-pci,fsdev=fs1,mount_tag=jeff-host-code
Then run the ltp test:
sudo bash /opt/ltp/runltp -f mm
The result is:
Test Start Time: Sat Nov 21 02:06:46 2020
-----------------------------------------
Testcase Result Exit Value
-------- ------ ----------
mm01 PASS 0
mm02 PASS 0
mtest01 PASS 0
mtest01w PASS 0
mtest05 PASS 0
mtest06 FAIL 2
mtest06_2 PASS 0
mtest06_3 PASS 0
mem02 PASS 0
mmapstress01 PASS 0
mmapstress02 PASS 0
mmapstress03 PASS 0
mmapstress04 PASS 0
mmapstress05 PASS 0
mmapstress06 PASS 0
mmapstress07 PASS 0
mmapstress08 PASS 0
mmapstress09 PASS 0
mmapstress10 PASS 0
mmap10 PASS 0
mmap10_1 PASS 0
mmap10_2 CONF 32
mmap10_3 CONF 32
mmap10_4 CONF 32
ksm01 CONF 32
ksm01_1 CONF 32
ksm02 CONF 32
ksm02_1 CONF 32
ksm03 CONF 32
ksm03_1 CONF 32
ksm04 CONF 32
ksm04_1 CONF 32
ksm05 CONF 32
ksm06 CONF 32
thp02 CONF 32
thp03 CONF 32
thp04 CONF 32
vma01 PASS 0
vma02 CONF 32
vma03 CONF 32
vma04 CONF 32
vma05 CONF 32
overcommit_memory01 PASS 0
overcommit_memory02 CONF 32
overcommit_memory03 PASS 0
overcommit_memory04 PASS 0
overcommit_memory05 PASS 0
overcommit_memory06 PASS 0
max_map_count PASS 0
min_free_kbytes PASS 0
-----------------------------------------------
Total Tests: 76
Total Skipped Tests: 29
Total Failures: 1
Kernel Version: 5.10.0-rc4+
Machine Architecture: x86_64
Hostname: ubuntu
The one failure happens without my change, too.(maybe my config is
not correct? I am not sure).
Last, i think this change have no problem.
And what's your opinions, Matthew.
Thanks.
next prev parent reply other threads:[~2020-11-20 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:12 [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Hui Su
2020-11-17 17:41 ` Matthew Wilcox
2020-11-17 17:46 ` Hui Su
2020-11-17 17:47 ` Matthew Wilcox
2020-11-17 17:56 ` Hui Su
2020-11-17 17:59 ` Matthew Wilcox
2020-11-17 18:05 ` Hui Su
2020-11-20 19:08 ` Hui Su [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 16:49 Hui Su
2020-11-17 16:53 ` Hui Su
2020-11-17 17:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120190852.GA19256@rlk \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).