* [PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning
@ 2020-11-28 15:41 Souptick Joarder
2020-11-30 13:18 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2020-11-28 15:41 UTC (permalink / raw)
To: hca, kbuild-all, svens
Cc: clang-built-linux, linux-mm, linux-kernel, Souptick Joarder
Kernel test robot generates below warning ->
>> arch/s390/kernel/vdso64/getcpu.c:8:5: warning: no previous prototype
>> for function '__s390_vdso_getcpu' [-Wmissing-prototypes]
int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
getcpu_cache *unused)
^
arch/s390/kernel/vdso64/getcpu.c:8:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
getcpu_cache *unused)
^
static
1 warning generated.
vim +/__s390_vdso_getcpu +8 arch/s390/kernel/vdso64/getcpu.c
7
> 8 int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
It is fixed by adding a prototype.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
include/linux/getcpu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/getcpu.h b/include/linux/getcpu.h
index c304dcd..43c9208 100644
--- a/include/linux/getcpu.h
+++ b/include/linux/getcpu.h
@@ -16,4 +16,5 @@ struct getcpu_cache {
unsigned long blob[128 / sizeof(long)];
};
+int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning
2020-11-28 15:41 [PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning Souptick Joarder
@ 2020-11-30 13:18 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2020-11-30 13:18 UTC (permalink / raw)
To: Souptick Joarder
Cc: kbuild-all, svens, clang-built-linux, linux-mm, linux-kernel
On Sat, Nov 28, 2020 at 09:11:57PM +0530, Souptick Joarder wrote:
> Kernel test robot generates below warning ->
>
> >> arch/s390/kernel/vdso64/getcpu.c:8:5: warning: no previous prototype
> >> for function '__s390_vdso_getcpu' [-Wmissing-prototypes]
> int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
> ^
> arch/s390/kernel/vdso64/getcpu.c:8:1: note: declare 'static' if the
> function is not intended to be used outside of this translation unit
> int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
> ^
> static
> 1 warning generated.
>
> vim +/__s390_vdso_getcpu +8 arch/s390/kernel/vdso64/getcpu.c
>
> 7
> > 8 int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> > getcpu_cache *unused)
>
> It is fixed by adding a prototype.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> include/linux/getcpu.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/getcpu.h b/include/linux/getcpu.h
> index c304dcd..43c9208 100644
> --- a/include/linux/getcpu.h
> +++ b/include/linux/getcpu.h
> @@ -16,4 +16,5 @@ struct getcpu_cache {
> unsigned long blob[128 / sizeof(long)];
> };
>
> +int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);
Sorry, no. We won't add s390 specific prototypes to common code header
files. Anyway, I solved this differently and the "fix" should be in
linux-next soon.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-28 15:41 [PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning Souptick Joarder
2020-11-30 13:18 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).