From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B085BC64E7A for ; Tue, 1 Dec 2020 22:28:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0168920671 for ; Tue, 1 Dec 2020 22:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0168920671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D4BD6B005C; Tue, 1 Dec 2020 17:28:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15F676B005D; Tue, 1 Dec 2020 17:28:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04DA28D0001; Tue, 1 Dec 2020 17:28:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id DC6476B005C for ; Tue, 1 Dec 2020 17:28:52 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D7AB1EF2 for ; Tue, 1 Dec 2020 22:28:52 +0000 (UTC) X-FDA: 77546154504.20.wing86_11077d3273ae Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 7AE3D180C07AB for ; Tue, 1 Dec 2020 22:28:52 +0000 (UTC) X-HE-Tag: wing86_11077d3273ae X-Filterd-Recvd-Size: 4471 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Dec 2020 22:28:51 +0000 (UTC) Received: from gaia (unknown [95.146.230.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7ECC82087C; Tue, 1 Dec 2020 22:28:49 +0000 (UTC) Date: Tue, 1 Dec 2020 22:28:47 +0000 From: Catalin Marinas To: Rob Herring Cc: kernel test robot , Nicolas Saenz Julienne , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List Subject: Re: [linux-next:master 6272/9613] unittest.c:undefined reference to `of_dma_get_max_cpu_address' Message-ID: <20201201222846.GA2646@gaia> References: <202012011747.PIcmivAO-lkp@intel.com> <20201201122915.GC31404@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 01, 2020 at 01:13:38PM -0700, Rob Herring wrote: > On Tue, Dec 1, 2020 at 5:29 AM Catalin Marinas wrote: > > On Tue, Dec 01, 2020 at 05:32:51PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: c6b11acc5f85b6e11d128fad8e0b7b223aa7e33f > > > commit: 07d13a1d6120d453c3c1f020578693d072deded5 [6272/9613] of: unittest: Add test for of_dma_get_max_cpu_address() > > > config: s390-randconfig-r034-20201201 (attached as .config) > > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install s390 cross compiling tool for clang build > > > # apt-get install binutils-s390x-linux-gnu > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07d13a1d6120d453c3c1f020578693d072deded5 > > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > git fetch --no-tags linux-next master > > > git checkout 07d13a1d6120d453c3c1f020578693d072deded5 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory': > > > coherent.c:(.text+0xf8): undefined reference to `memunmap' > > > s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory': > > > coherent.c:(.text+0x174): undefined reference to `memremap' > > > s390x-linux-gnu-ld: coherent.c:(.text+0x344): undefined reference to `memunmap' > > > s390x-linux-gnu-ld: drivers/of/unittest.o: in function `of_unittest': > > > >> unittest.c:(.init.text+0x120): undefined reference to `of_dma_get_max_cpu_address' > > > > Thanks for the report. I think it needs the diff below. If Rob/Nicolas > > are ok with it, I'll add it to the arm64 tree (with some commit text): > > > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > > index 98cc0163301b..799125ef66fc 100644 > > --- a/drivers/of/unittest.c > > +++ b/drivers/of/unittest.c > > @@ -871,6 +871,7 @@ static void __init of_unittest_changeset(void) > > > > static void __init of_unittest_dma_get_max_cpu_address(void) > > { > > +#ifdef CONFIG_OF_ADDRESS > > if (!IS_ENABLED(CONFIG_OF_ADDRESS)) > return; I can change it. I saw two other instances of #ifdef style, so I went with this. > This once again makes me want to kill off HAS_IOMEM. Or at least > always have a dummy ioremap() and friends for !HAS_IOMEM. That's for a different patch series I guess ;). -- Catalin