From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=g5mM=FG=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 484D6C64E7C
	for <linux-mm@archiver.kernel.org>; Wed,  2 Dec 2020 10:05:40 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 7264E221FA
	for <linux-mm@archiver.kernel.org>; Wed,  2 Dec 2020 10:05:39 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7264E221FA
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 427676B005C; Wed,  2 Dec 2020 05:05:38 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 3D7268D0002; Wed,  2 Dec 2020 05:05:38 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 2EDD98D0001; Wed,  2 Dec 2020 05:05:38 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7])
	by kanga.kvack.org (Postfix) with ESMTP id 15EB66B005C
	for <linux-mm@kvack.org>; Wed,  2 Dec 2020 05:05:38 -0500 (EST)
Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay01.hostedemail.com (Postfix) with ESMTP id AC2AA180AD804
	for <linux-mm@kvack.org>; Wed,  2 Dec 2020 10:05:37 +0000 (UTC)
X-FDA: 77547910314.19.color78_09185ec273b2
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin19.hostedemail.com (Postfix) with ESMTP id 0AD1D1ACC22
	for <linux-mm@kvack.org>; Wed,  2 Dec 2020 10:05:36 +0000 (UTC)
X-HE-Tag: color78_09185ec273b2
X-Filterd-Recvd-Size: 1562
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf01.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Wed,  2 Dec 2020 10:05:36 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id 00B9368AFE; Wed,  2 Dec 2020 11:05:32 +0100 (CET)
Date: Wed, 2 Dec 2020 11:05:32 +0100
From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Zi Yan <ziy@nvidia.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	William Kucharski <william.kucharski@oracle.com>,
	"Thomas Hellstrom (VMware)" <thomas_os@shipmail.org>,
	Michel Lespinasse <walken@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] include/linux/huge_mm.h: remove extern keyword
Message-ID: <20201202100532.GA7597@lst.de>
References: <20201106235135.32109-1-rcampbell@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201106235135.32109-1-rcampbell@nvidia.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Fri, Nov 06, 2020 at 03:51:35PM -0800, Ralph Campbell wrote:
> The external function definitions don't need the "extern" keyword.
> Remove them so future changes don't copy the function definition style.
> 
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>