From: Matthew Wilcox <willy@infradead.org>
To: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [RFC PATCH 1/1] mm/hugetlb: clear compound_nr before freeing gigantic pages
Date: Tue, 8 Dec 2020 18:55:30 +0000 [thread overview]
Message-ID: <20201208185530.GJ7338@casper.infradead.org> (raw)
In-Reply-To: <20201208182813.66391-2-gerald.schaefer@linux.ibm.com>
On Tue, Dec 08, 2020 at 07:28:13PM +0100, Gerald Schaefer wrote:
> This is because only the compound_order is cleared in
> destroy_compound_gigantic_page(), and compound_nr is set to 1U << order == 1
> for order 0 in set_compound_order(page, 0).
I didn't realise there was a separate destroy path for gigantic pages.
Thanks for catching and fixing this.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2020-12-08 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 18:28 [RFC PATCH 0/1] "Bad page state" while freeing gigantic pages Gerald Schaefer
2020-12-08 18:28 ` [RFC PATCH 1/1] mm/hugetlb: clear compound_nr before " Gerald Schaefer
2020-12-08 18:55 ` Matthew Wilcox [this message]
2020-12-08 18:35 ` [RFC PATCH 0/1] "Bad page state" while " Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208185530.GJ7338@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).