From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23597C433E0 for ; Mon, 21 Dec 2020 06:35:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3DC122CAF for ; Mon, 21 Dec 2020 06:35:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3DC122CAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB0DF6B0073; Mon, 21 Dec 2020 01:35:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D600D8D0002; Mon, 21 Dec 2020 01:35:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4C808D0001; Mon, 21 Dec 2020 01:35:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id AE1E76B0073 for ; Mon, 21 Dec 2020 01:35:18 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6CD5E180ACF75 for ; Mon, 21 Dec 2020 06:35:18 +0000 (UTC) X-FDA: 77616327516.04.boat64_340621c27455 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 53F728001D03 for ; Mon, 21 Dec 2020 06:35:18 +0000 (UTC) X-HE-Tag: boat64_340621c27455 X-Filterd-Recvd-Size: 2704 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 06:35:17 +0000 (UTC) Date: Mon, 21 Dec 2020 08:35:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608532516; bh=CDzFFK1gZq+ZpVRYJf1GjMW3wuMU9Dcb6QR1oomaDfM=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=OMF06ym19B/k2FQ2dIssmTAfwFEO/FxjVmoA6sZJ3fyaohMGhiAnlt57zPB0j75kM aOWGpRr9uhBmdyO79DEar2tM4wz5kKA79Hrnfxf0haI9yiRiWgGjqkAgq1OkBznrp6 s+r+lGPBDXs62/ZJdam993Zf12zjt+o9iDon0+idOFVsbBvSKR/bYCDo1YFKIkyTpI DLhniYs2Grw3DTzVFIMI5hJ5GqpRgY8I3mWnM6upskVu2FY18DJEbC2U48QeyDF77b f99Z4UabATOTtwxPCzA70lrDNv0sCsWFvYYAvkoW9qneIAxpdw+A9XTU9fs2F2iNpq xEve3WA9sjQgQ== From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, gopakumarr@vmware.com, david@redhat.com Subject: Re: [PATCH v2 5/5] mm: remove unneeded local variable in free_area_init_core Message-ID: <20201221063509.GG392325@kernel.org> References: <20201220082754.6900-1-bhe@redhat.com> <20201220082754.6900-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201220082754.6900-6-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 20, 2020 at 04:27:54PM +0800, Baoquan He wrote: > Local variable 'zone_start_pfn' is not needed since there's only > one call site in free_area_init_core(). Let's remove it and pass > zone->zone_start_pfn directly to init_currently_empty_zone(). > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- > mm/page_alloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7f0a917ab858..189a86253c93 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6986,7 +6986,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > for (j = 0; j < MAX_NR_ZONES; j++) { > struct zone *zone = pgdat->node_zones + j; > unsigned long size, freesize, memmap_pages; > - unsigned long zone_start_pfn = zone->zone_start_pfn; > > size = zone->spanned_pages; > freesize = zone->present_pages; > @@ -7035,7 +7034,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > > set_pageblock_order(); > setup_usemap(zone); > - init_currently_empty_zone(zone, zone_start_pfn, size); > + init_currently_empty_zone(zone, zone->zone_start_pfn, size); > memmap_init_zone(zone); > } > } > -- > 2.17.2 > -- Sincerely yours, Mike.