From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DE6C433DB for ; Sat, 26 Dec 2020 21:42:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B9FD21D7A for ; Sat, 26 Dec 2020 21:42:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B9FD21D7A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C4908D0094; Sat, 26 Dec 2020 16:42:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9745D8D0080; Sat, 26 Dec 2020 16:42:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 814618D0094; Sat, 26 Dec 2020 16:42:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 69E998D0080 for ; Sat, 26 Dec 2020 16:42:47 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1D1A9181AEF0B for ; Sat, 26 Dec 2020 21:42:47 +0000 (UTC) X-FDA: 77636758374.04.slip43_410ad9127485 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 05BA38006429 for ; Sat, 26 Dec 2020 21:42:46 +0000 (UTC) X-HE-Tag: slip43_410ad9127485 X-Filterd-Recvd-Size: 3033 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Sat, 26 Dec 2020 21:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4olHbSDjwG6n/OG9RW7BnLDOSD34WqpyWEqi+69B4eE=; b=YCjWq3kWsb8g53CSpAlmT2oaBJ nC3GR3LqUiN58lfPazvooKGIqeZw+N8fT/SjFreJtYzhNVnSPkwxr9kry2bsF/o3CmwIWm8bQkX7E HPXqNppGbGwdHXE4ceNhseY+eTumJa1pasQp7UjZSKq9L7h0sz6yNdUGIiCyreO5zIFaEIpU6gTiU F7YxNhV07CE+NOUky2TE+Bh3MnSQOdMcGM5cYsrLQeI+dDk1uU2iQFPcW8mpioX4hQ+Wgx17rwb+7 1bCLlHh6ZB19a58yalcvBYWRf7CLrHts52+R64fkG2HsCaud6HSHMSy7QjTkKB4PZtZQXk/JNpqZk JoseuZDw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktHJC-0001eD-Cl; Sat, 26 Dec 2020 21:41:17 +0000 Date: Sat, 26 Dec 2020 21:41:06 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Linus Torvalds , Hugh Dickins , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , Vinayak Menon , Android Kernel Team Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting Message-ID: <20201226214106.GA5479@casper.infradead.org> References: <20201218110400.yve45r3zsv7qgfa3@box> <20201219124103.w6isern3ywc7xbur@box> <20201222100047.p5zdb4ghagncq2oe@box> <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201226204335.dikqkrkezqet6oqf@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 26, 2020 at 11:43:35PM +0300, Kirill A. Shutemov wrote: > +static struct page *next_stable_page(struct page *page, struct vm_fault *vmf, > + struct xa_state *xas, pgoff_t end_pgoff) A "stable page" means one that doesn't currently have an outstanding write (see wait_for_stable_page()). It's really "Next trivially insertable page". I might call it "next_uptodate_page()" and gloss over the other reasons this might fail to return a page.