* Re: [PATCH v1 11/13] sparc32: Drop unused mmu models
[not found] <20201218184347.2180772-12-sam@ravnborg.org>
@ 2020-12-30 6:26 ` kernel test robot
2020-12-30 6:26 ` [PATCH] sparc32: fix badzero.cocci warnings kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-12-30 6:26 UTC (permalink / raw)
To: Sam Ravnborg, David S Miller, sparclinux, Andreas Larsson,
Arnd Bergmann
Cc: kbuild-all, Alexey Dobriyan, Al Viro, Andrew Morton,
Linux Memory Management List, Anshuman Khandual, Arvind Sankar
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
Hi Sam,
I love your patch! Perhaps something to improve:
[auto build test WARNING on soc/for-next]
[also build test WARNING on sparc/master v5.11-rc1 next-20201223]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/sparc32-sunset-sun4m-and-sun4d/20201219-025354
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: sparc-randconfig-c004-20201229 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"coccinelle warnings: (new ones prefixed by >>)"
>> arch/sparc/mm/srmmu.c:317:42-43: WARNING comparing pointer to 0
>> arch/sparc/mm/srmmu.c:317:42-43: WARNING comparing pointer to 0
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19461 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] sparc32: fix badzero.cocci warnings
[not found] <20201218184347.2180772-12-sam@ravnborg.org>
2020-12-30 6:26 ` [PATCH v1 11/13] sparc32: Drop unused mmu models kernel test robot
@ 2020-12-30 6:26 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-12-30 6:26 UTC (permalink / raw)
To: Sam Ravnborg, David S Miller, sparclinux, Andreas Larsson,
Arnd Bergmann
Cc: kbuild-all, Alexey Dobriyan, Al Viro, Andrew Morton,
Linux Memory Management List, Anshuman Khandual, Arvind Sankar
From: kernel test robot <lkp@intel.com>
arch/sparc/mm/srmmu.c:317:42-43: WARNING comparing pointer to 0
arch/sparc/mm/srmmu.c:317:42-43: WARNING comparing pointer to 0
Compare pointer-typed values to NULL rather than 0
Semantic patch information:
This makes an effort to choose between !x and x == NULL. !x is used
if it has previously been used with the function used to initialize x.
This relies on type information. More type information can be obtained
using the option -all_includes and the option -I to specify an
include path.
Generated by: scripts/coccinelle/null/badzero.cocci
CC: Sam Ravnborg <sam@ravnborg.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/sparc32-sunset-sun4m-and-sun4d/20201219-025354
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
srmmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -314,7 +314,7 @@ pgtable_t pte_alloc_one(struct mm_struct
pte_t *ptep;
struct page *page;
- if ((ptep = pte_alloc_one_kernel(mm)) == 0)
+ if ((ptep = pte_alloc_one_kernel(mm)) == NULL)
return NULL;
page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT);
spin_lock(&mm->page_table_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread