From: Michal Hocko <mhocko@suse.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: uninitialized pmem struct pages
Date: Tue, 5 Jan 2021 08:40:52 +0100 [thread overview]
Message-ID: <20210105074052.GQ13207@dhcp22.suse.cz> (raw)
In-Reply-To: <CAPcyv4jGhvfDeFkY=R9+2QB3vZvRfJ=6s9o29U7msVemGhJjzw@mail.gmail.com>
On Mon 04-01-21 21:33:06, Dan Williams wrote:
> On Mon, Jan 4, 2021 at 7:59 AM Michal Hocko <mhocko@suse.com> wrote:
[...]
> > Not sure what exactly you are asking for but crash says
> > crash> kmem -p 6060000
> > PAGE PHYSICAL MAPPING INDEX CNT FLAGS
> > fffff8c600181800 6060000 0 0 0 fffffc0000000
> >
> > > I do wonder what hosts pfn_to_page(PHYS_PFN(0x6060000)) - is it actually
> > > part of the actual altmap (i.e. > 0x6060000) or maybe even self-hosted?
> >
> > I am not really familiar with the pmem so I would need more assistance
> > here. I've tried this (shot into the dark):
> > crash> struct page.pgmap fffff8c600181800
> > pgmap = 0xfffff8c600181808
>
> Does /proc/iomem show an active namespace in the range?
Any tips how I dig that out from the crash dump?
> You should be
> able to skip ahead to the first pfn in that namespace to find the
> first dev_pagemap. I would have expected pfn_to_online_page() to have
> saved you here. This address range is section aligned.
Well, the affected code in this case was
end_pfn = min(start_pfn + nr_pages,
zone_end_pfn(page_zone(pfn_to_page(start_pfn))));
where start_pfn was the first pfn of a memory section. This code was
completely unaware of zone device or dev_pagemap like most others pfn
walkers. It just wanted to get bounds for the zone but it stumbled over
uninitialized zone/node.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-01-05 7:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 10:03 uninitialized pmem struct pages Michal Hocko
2021-01-04 10:45 ` David Hildenbrand
2021-01-04 14:26 ` Michal Hocko
2021-01-04 14:51 ` David Hildenbrand
2021-01-04 15:10 ` Michal Hocko
2021-01-04 15:15 ` David Hildenbrand
2021-01-04 15:33 ` Michal Hocko
2021-01-04 15:43 ` David Hildenbrand
2021-01-04 15:44 ` David Hildenbrand
2021-01-05 8:00 ` Michal Hocko
2021-01-05 8:16 ` Michal Hocko
2021-01-05 8:27 ` Dan Williams
2021-01-05 8:42 ` Michal Hocko
2021-01-05 8:57 ` Dan Williams
2021-01-05 9:05 ` Michal Hocko
2021-01-05 9:13 ` David Hildenbrand
2021-01-05 9:25 ` Michal Hocko
2021-01-05 9:27 ` David Hildenbrand
2021-01-04 15:59 ` Michal Hocko
2021-01-04 16:30 ` David Hildenbrand
2021-01-05 7:44 ` Michal Hocko
2021-01-05 9:56 ` David Hildenbrand
2021-01-05 5:33 ` Dan Williams
2021-01-05 7:40 ` Michal Hocko [this message]
2021-01-05 5:17 ` Dan Williams
2021-01-05 7:50 ` Michal Hocko
2021-01-05 9:16 ` David Hildenbrand
2021-01-05 9:25 ` David Hildenbrand
2021-01-05 9:33 ` Dan Williams
2021-01-05 9:37 ` David Hildenbrand
2021-01-05 9:56 ` Dan Williams
2021-01-05 9:58 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105074052.GQ13207@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox