Re: [PATCH 1/2] x86/setup: consolidate early memory reservations

Mike Rapoport
2021-01-25T15:33:16Z

On Mon, Jan 25, 2021 at 03:59:11PM +0100, Borislav Petkov wrote:
> On Fri, Jan 15, 2021 at 10:32:54AM +0200, Mike Rapoport wrote:
> > + trim_low_memory_range();
>
> Btw, you can get rid of that one too:
>
> /*
> * Here we put platform-specific memory range workarounds, i.e.
> * memory known to be corrupt or otherwise in need to be reserved on
> * specific platforms.
> *
> * If this gets used more widely it could use a real dispatch mechanism.
> */
> static void __init trim_platform_memory_ranges(void)
> {
> trim_snb_memory();
> }
>
> yeah, yeah, we can do a real dispatch mechanism but we didn't need one
> since 2012 so I guess we can get rid of trim_platform_memory_ranges()
> and call trim_snb_memory() directly and simplify it even more.

Ok.

> Thx.
>

--
Sincerely yours,
Mike.