From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32585C433DB for ; Mon, 1 Feb 2021 12:22:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B3EE64E94 for ; Mon, 1 Feb 2021 12:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B3EE64E94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9427D6B0070; Mon, 1 Feb 2021 07:22:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F2466B0071; Mon, 1 Feb 2021 07:22:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 793066B0073; Mon, 1 Feb 2021 07:22:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 5FDB56B0070 for ; Mon, 1 Feb 2021 07:22:09 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 259F98249980 for ; Mon, 1 Feb 2021 12:22:09 +0000 (UTC) X-FDA: 77769611178.09.cord55_4d01173275c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 0A6A8180AD81F for ; Mon, 1 Feb 2021 12:22:09 +0000 (UTC) X-HE-Tag: cord55_4d01173275c2 X-Filterd-Recvd-Size: 2550 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 12:22:08 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CCB7C6736F; Mon, 1 Feb 2021 13:22:04 +0100 (CET) Date: Mon, 1 Feb 2021 13:22:04 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Song Liu , Jaegeuk Kim , Chao Yu , Philipp Reisner , Lars Ellenberg , Coly Li , Mike Snitzer , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Andrew Morton , Ryusuke Konishi , linux-nilfs@vger.kernel.org, dm-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/17] block: split bio_kmalloc from bio_alloc_bioset Message-ID: <20210201122204.GA22727@lst.de> References: <20210126145247.1964410-1-hch@lst.de> <20210126145247.1964410-5-hch@lst.de> <20210130035646.GH308988@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210130035646.GH308988@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 30, 2021 at 03:56:46AM +0000, Matthew Wilcox wrote: > On Tue, Jan 26, 2021 at 03:52:34PM +0100, Christoph Hellwig wrote: > > bio_kmalloc shares almost no logic with the bio_set based fast path > > in bio_alloc_bioset. Split it into an entirely separate implementation. > > > > Signed-off-by: Christoph Hellwig > > --- > > block/bio.c | 167 ++++++++++++++++++++++---------------------- > > include/linux/bio.h | 6 +- > > 2 files changed, 86 insertions(+), 87 deletions(-) > > This patch causes current linux-next to OOM for me when running xfstests > after about ten minutes. Haven't looked into why yet, this is just the > results of a git bisect. I've run tests on linux-next all weekend and could not reproduce the issue. Can you share your .config?