From: kernel test robot <lkp@intel.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com,
david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com,
sashal@kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v9 08/14] mm/gup: do not migrate zero page
Date: Tue, 2 Feb 2021 10:41:58 +0800 [thread overview]
Message-ID: <202102021007.udwVXuwA-lkp@intel.com> (raw)
In-Reply-To: <20210201153827.444374-9-pasha.tatashin@soleen.com>
[-- Attachment #1: Type: text/plain, Size: 4295 bytes --]
Hi Pavel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kselftest/next]
[also build test ERROR on tip/sched/core tip/perf/core linux/master next-20210125]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pavel-Tatashin/prohibit-pinning-pages-in-ZONE_MOVABLE/20210201-234048
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: arm-randconfig-r031-20210201 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/0871f9d0d8c84d31549b4771af9d60ce3b1aecb2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pavel-Tatashin/prohibit-pinning-pages-in-ZONE_MOVABLE/20210201-234048
git checkout 0871f9d0d8c84d31549b4771af9d60ce3b1aecb2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/arm/kernel/asm-offsets.c:12:
>> include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]
is_zero_pfn(page_to_pfn(page));
^
include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
static inline bool is_zero_ino(ino_t ino)
^
1 error generated.
--
In file included from arch/arm/kernel/asm-offsets.c:12:
>> include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]
is_zero_pfn(page_to_pfn(page));
^
include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
static inline bool is_zero_ino(ino_t ino)
^
1 error generated.
make[2]: *** [scripts/Makefile.build:117: arch/arm/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1206: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from arch/arm/kernel/asm-offsets.c:12:
>> include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]
is_zero_pfn(page_to_pfn(page));
^
include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
static inline bool is_zero_ino(ino_t ino)
^
1 error generated.
make[2]: *** [scripts/Makefile.build:117: arch/arm/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1206: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/is_zero_pfn +1128 include/linux/mm.h
1123
1124 /* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */
1125 static inline bool is_pinnable_page(struct page *page)
1126 {
1127 return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) ||
> 1128 is_zero_pfn(page_to_pfn(page));
1129 }
1130
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30618 bytes --]
next prev parent reply other threads:[~2021-02-02 2:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 15:38 [PATCH v9 00/14] prohibit pinning pages in ZONE_MOVABLE Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 01/14] mm/gup: don't pin migrated cma pages in movable zone Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 02/14] mm/gup: check every subpage of a compound page during isolation Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 03/14] mm/gup: return an error on migration failure Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 04/14] mm/gup: check for isolation errors Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 05/14] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 06/14] mm: apply per-task gfp constraints in fast path Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 07/14] mm: honor PF_MEMALLOC_PIN for all movable pages Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 08/14] mm/gup: do not migrate zero page Pavel Tatashin
2021-02-02 2:41 ` kernel test robot [this message]
2021-02-02 4:05 ` Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 09/14] mm/gup: migrate pinned pages out of movable zone Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 10/14] memory-hotplug.rst: add a note about ZONE_MOVABLE and page pinning Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 11/14] mm/gup: change index type to long as it counts pages Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 12/14] mm/gup: longterm pin migration cleanup Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 13/14] selftests/vm: gup_test: fix test flag Pavel Tatashin
2021-02-01 15:38 ` [PATCH v9 14/14] selftests/vm: gup_test: test faulting in kernel, and verify pinnable pages Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102021007.udwVXuwA-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox