From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A972C433E0 for ; Thu, 4 Feb 2021 00:34:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB75764F5F for ; Thu, 4 Feb 2021 00:34:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB75764F5F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 30DFB6B007D; Wed, 3 Feb 2021 19:34:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BE4C6B007E; Wed, 3 Feb 2021 19:34:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D42D6B0083; Wed, 3 Feb 2021 19:34:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 0554D6B007D for ; Wed, 3 Feb 2021 19:34:41 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C75838249980 for ; Thu, 4 Feb 2021 00:34:40 +0000 (UTC) X-FDA: 77778714720.13.eye22_3703a35275d7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id AF71118140B67 for ; Thu, 4 Feb 2021 00:34:40 +0000 (UTC) X-HE-Tag: eye22_3703a35275d7 X-Filterd-Recvd-Size: 2163 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 00:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WtqSZ5oXvmEMoh+hrHkKFwo4xVGvGfHlBaygywAwMRc=; b=bV/LOyPvR3YFi448R5iR0V9ZkH Ifd2R06/CmXMjYSq2kHoj3ImbwBurDCzkOGgDGGLpKqpbYf/Vt8nkFTyC33iFq1+EX7HyGg1Wpoxq p7MMaFCswRhLvya4pvflqRE53U7fL/2Fwq4rhadyQiuWI8+NCpvJtzBSJEl+yN1D2zvtZyFYTMfWR DxDLmKBYFgVc2z0Nub49BqNHDh87smKk4EJXvJq6LCIhb6DAQYrrdEaQP/FWqHuelDDoOgRH25TDE aOTZLDFJLkpRVusKePNwtQyjW4U0ugbf3BERiv0Tc58lBXBmtT/QwLh31xMkoezEe5i4FyrFroKbN uQ+R4gPA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l7SbK-0008gX-8u; Thu, 04 Feb 2021 00:34:26 +0000 Date: Thu, 4 Feb 2021 00:34:26 +0000 From: Matthew Wilcox To: Chris Goldsworthy Cc: Andrew Morton , Alexander Viro , Minchan Kim , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] mm: fs: Invalidate BH LRU during page migration Message-ID: <20210204003426.GC308988@casper.infradead.org> References: <695193a165bf538f35de84334b4da2cc3544abe0.1612248395.git.cgoldswo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <695193a165bf538f35de84334b4da2cc3544abe0.1612248395.git.cgoldswo@codeaurora.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 10:55:47PM -0800, Chris Goldsworthy wrote: > @@ -1289,6 +1289,8 @@ static inline void check_irqs_on(void) > #endif > } > > +bool bh_migration_done = true; What protects this global variable? Or is there some subtle reason it doesn't need protection, in which case, please put that in a comment.