From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72813C433E0 for ; Thu, 4 Feb 2021 19:52:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0087464F45 for ; Thu, 4 Feb 2021 19:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0087464F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86D826B0070; Thu, 4 Feb 2021 14:52:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 842366B0071; Thu, 4 Feb 2021 14:52:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77F4F6B0072; Thu, 4 Feb 2021 14:52:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 61A106B0070 for ; Thu, 4 Feb 2021 14:52:25 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2ABFE8249980 for ; Thu, 4 Feb 2021 19:52:25 +0000 (UTC) X-FDA: 77781632250.17.yard55_3e07ded275de Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 11A86180D0180 for ; Thu, 4 Feb 2021 19:52:25 +0000 (UTC) X-HE-Tag: yard55_3e07ded275de X-Filterd-Recvd-Size: 3111 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 19:52:22 +0000 (UTC) IronPort-SDR: q/QKSY7AmjaUW4GDxZT32wu9+A0gGkADkVH49uzLaLlEe7C3dkEaUDXD8phnDO+QjDvoyy05UW wW0mYEr2K/hg== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="242822626" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="242822626" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:21 -0800 IronPort-SDR: lk2OeIHmNPWbmvRojJjqR8Xtfh20RG7xmOB4Z1oM64zOBayunz7AhdCrNPMsooc6EW9bI/cxGe DT69vT3vA40Q== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="434088875" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:20 -0800 Date: Thu, 4 Feb 2021 11:52:20 -0800 From: Jesse Brandeburg To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Message-ID: <20210204115220.0000018d@intel.com> In-Reply-To: <20210202133030.5760-5-alobakin@pm.me> References: <20210202133030.5760-1-alobakin@pm.me> <20210202133030.5760-5-alobakin@pm.me> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander Lobakin wrote: > Now we can remove a bunch of identical functions from the drivers and > make them use common dev_page_is_reusable(). All {,un}likely() checks > are omitted since it's already present in this helper. > Also update some comments near the call sites. > > Suggested-by: David Rientjes > Suggested-by: Jakub Kicinski > Cc: John Hubbard > Signed-off-by: Alexander Lobakin I don't know why it was missed in the series update, but: Reviewed-by: Jesse Brandeburg