From: Jason Gunthorpe <jgg@ziepe.ca>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
dan.j.williams@intel.com
Subject: Re: [PATCH 1/2] mm: provide a sane PTE walking API for modules
Date: Fri, 5 Feb 2021 09:49:27 -0400 [thread overview]
Message-ID: <20210205134927.GL4718@ziepe.ca> (raw)
In-Reply-To: <20210205103259.42866-2-pbonzini@redhat.com>
On Fri, Feb 05, 2021 at 05:32:58AM -0500, Paolo Bonzini wrote:
> Currently, the follow_pfn function is exported for modules but
> follow_pte is not. However, follow_pfn is very easy to misuse,
> because it does not provide protections (so most of its callers
> assume the page is writable!) and because it returns after having
> already unlocked the page table lock.
>
> Provide instead a simplified version of follow_pte that does
> not have the pmdpp and range arguments. The older version
> survives as follow_invalidate_pte() for use by fs/dax.c.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/s390/pci/pci_mmio.c | 2 +-
> fs/dax.c | 5 +++--
> include/linux/mm.h | 6 ++++--
> mm/memory.c | 35 ++++++++++++++++++++++++++++++-----
> 4 files changed, 38 insertions(+), 10 deletions(-)
Looks good to me, thanks
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2021-02-05 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:32 [PATCH 0/2] KVM: do not assume PTE is writable after follow_pfn Paolo Bonzini
2021-02-05 10:32 ` [PATCH 1/2] mm: provide a sane PTE walking API for modules Paolo Bonzini
2021-02-05 13:49 ` Jason Gunthorpe [this message]
2021-02-08 17:39 ` Christoph Hellwig
2021-02-08 18:18 ` Paolo Bonzini
2021-02-09 8:14 ` Christoph Hellwig
2021-02-09 9:19 ` Paolo Bonzini
2021-02-05 10:32 ` [PATCH 2/2] KVM: do not assume PTE is writable after follow_pfn Paolo Bonzini
2021-02-05 15:43 ` kernel test robot
2021-02-05 17:41 ` kernel test robot
2021-02-05 18:14 ` [PATCH 0/2] " Peter Xu
2021-02-08 18:51 ` Jason Gunthorpe
2021-02-08 22:02 ` Peter Xu
2021-02-08 23:26 ` Jason Gunthorpe
2021-02-09 0:23 ` Peter Xu
2021-02-09 8:19 ` Christoph Hellwig
2021-02-09 10:02 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205134927.GL4718@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).